Skip to content

Comments

feat: [DTOSS-9558] diagnostic settings for storage accounts#1837

Merged
MacMur85 merged 1 commit intomainfrom
feat/DTOSS-9558-diagnostic-settings-for-storage-accounts
Feb 18, 2026
Merged

feat: [DTOSS-9558] diagnostic settings for storage accounts#1837
MacMur85 merged 1 commit intomainfrom
feat/DTOSS-9558-diagnostic-settings-for-storage-accounts

Conversation

@MacMur85
Copy link
Contributor

@MacMur85 MacMur85 commented Feb 11, 2026

Description

This PR is a part of a change responsible for enabling Diagnostic Settings Metrics on Storage Accounts themselves.
Previously we've had diagnostics enabled on Storage Accounts' services, like blobs and file shares, but not on Storage Accounts themselves.

Context

There is also a PR in the templates repository (PR227), that needs to be merged in first.

Plan:
image

Before:
image

Ater:
image

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@MacMur85 MacMur85 changed the title feat: [DTOSS-9558} diagnostic settings for storage accounts feat: [DTOSS-9558] diagnostic settings for storage accounts Feb 11, 2026
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Unit Test Results

✔️ Tests 975 / 975 - passed in 70.9s
📝 Coverage 47.76%
📏 4756 / 10229 lines covered 🌿 1167 / 2172 branches covered
🔍 click here for more details

✏️ updated for commit 6831f9e

rfk-nc
rfk-nc previously approved these changes Feb 12, 2026
nc-shahidazim
nc-shahidazim previously approved these changes Feb 12, 2026
Copy link
Contributor

@nc-shahidazim nc-shahidazim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MacMur85 MacMur85 dismissed stale reviews from nc-shahidazim and rfk-nc via c98fc49 February 17, 2026 20:06
@MacMur85 MacMur85 marked this pull request as ready for review February 17, 2026 20:13
@MacMur85 MacMur85 force-pushed the feat/DTOSS-9558-diagnostic-settings-for-storage-accounts branch from c98fc49 to f3c97b8 Compare February 17, 2026 20:14
@MacMur85 MacMur85 force-pushed the feat/DTOSS-9558-diagnostic-settings-for-storage-accounts branch from f3c97b8 to 6831f9e Compare February 17, 2026 20:15
@sonarqubecloud
Copy link

@rfk-nc rfk-nc added the Non-functional change A change that does not change any functions. Mainly config or database changes label Feb 18, 2026
Copy link
Contributor

@nc-shahidazim nc-shahidazim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MacMur85 MacMur85 added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 3deb3a9 Feb 18, 2026
67 checks passed
@MacMur85 MacMur85 deleted the feat/DTOSS-9558-diagnostic-settings-for-storage-accounts branch February 18, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Non-functional change A change that does not change any functions. Mainly config or database changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants