Skip to content

fix: removing the deprecated enabled value for diagnostic settings metrics #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MacMur85 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: removing the deprecated enabled value for diagnostic settings metrics #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion infrastructure/modules/api-management/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,5 @@ module "diagnostic-settings" {
log_analytics_workspace_id = var.log_analytics_workspace_id
enabled_log = var.monitor_diagnostic_setting_apim_enabled_logs
enabled_metric = var.monitor_diagnostic_setting_apim_metrics
metric_enabled = var.metric_enabled

}
1 change: 0 additions & 1 deletion infrastructure/modules/cdn-frontdoor-profile/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,5 @@ module "diagnostic-settings" {
log_analytics_workspace_id = var.log_analytics_workspace_id
enabled_log = var.monitor_diagnostic_setting_frontdoor_enabled_logs
enabled_metric = var.monitor_diagnostic_setting_frontdoor_metrics
metric_enabled = var.metric_enabled

}
6 changes: 0 additions & 6 deletions infrastructure/modules/cdn-frontdoor-profile/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ variable "log_analytics_workspace_id" {
default = null
}

variable "metric_enabled" {
type = bool
description = "Enables retention for diagnostic settings metric"
default = true
}

variable "monitor_diagnostic_setting_frontdoor_enabled_logs" {
type = list(string)
description = "Controls which logs will be enabled for the Front Door profile"
Expand Down
1 change: 0 additions & 1 deletion infrastructure/modules/key-vault/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ module "diagnostic-settings" {
log_analytics_workspace_id = var.log_analytics_workspace_id
enabled_log = var.monitor_diagnostic_setting_keyvault_enabled_logs
enabled_metric = var.monitor_diagnostic_setting_keyvault_metrics
metric_enabled = var.metric_enabled
}

data "azurerm_client_config" "current" {}
6 changes: 0 additions & 6 deletions infrastructure/modules/key-vault/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ variable "log_analytics_workspace_id" {
description = "id of the log analytics workspace to send resource logging to via diagnostic settings"
}

variable "metric_enabled" {
type = bool
description = "to enable retention for diagnostic settings metric"
default = true
}

variable "monitor_diagnostic_setting_keyvault_enabled_logs" {
type = list(string)
description = "Controls what logs will be enabled for the keyvault"
Expand Down