Snagging updates #852
Merged
Snagging updates #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeng
reviewed
Dec 19, 2025
Contributor
gpeng
left a comment
gpeng
left a comment
There was a problem hiding this comment.
Good stuff. I've added a couple of comments. I know you've only opened it as draft but I'm off now. @malcolmbaig can give you a hand next week. Could you also rebase from main instead of merging to avoid that 🤮 merge commit 😁
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11864-snagging-updates
branch
from
cde8cea to
329adb6
Compare
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11864-snagging-updates
branch
from
329adb6 to
3c21535
Compare
malcolmbaig
reviewed
Dec 24, 2025
manage_breast_screening/tests/system/clinical/test_clinic_show_page.py
Outdated
Show resolved
Hide resolved
Contributor
|
Commit messages look good. A useful convention for the message body is to format it with a max width of 72 characters. This keeps the git log easy to read (especially when viewed in narrow windows/splits) and consistent with the rest of the commit history. You can set up whichever editor you use for commit messages to enforce the 72 char width. |
this has been changed to fit in with design standards as the date/time font is a secondary text
As all of our clinical types will be Screening this column is redundant information
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11864-snagging-updates
branch
from
3c21535 to
4304cd2
Compare
Added to fit in line with the prototype after snagging session
This has been changed as if we collect all clinics, this list will grow very large and will get out of control very quick. This has been changed to the last 7 days and can be more digestable
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11864-snagging-updates
branch
from
4304cd2 to
96492fe
Compare
|
malcolmbaig
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor updates to the /clinics page that have been found in a snagging session referencing against the prototype.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11864
Review notes
Review checklist