Skip to content

Conversation

@malcolmbaig
Copy link
Contributor

@malcolmbaig malcolmbaig commented Dec 24, 2025

Description

  • Add these buttons to the top and bottom of the page, as submit buttons
    on a form that POSTs to the current URL
  • Rework RecordMedicalInformationForm to back these forms, and have its
    save function create all missing medical info review records for the
    appointment
  • Have the view wrap the save call to this form in a transaction (as
    we're potentially writing multiple database records)
  • Redirect to Awaiting Images when done
Screenshot 2025-12-24 at 11 53 10

Jira link

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11591

Review notes

We'll likely want to revisit how we implement wizard_step.jinja as we build the new workflow pages out, but for now I've added the ability to override the default 'continue' form at the bottom of the page.

Review checklist

  • Check database queries are correctly scoped to current_provider

Make it so that any template extending wizard_step can override the form
rendered at the bottom of the page. We'll need this as we transition
from the existing design of the appointment pages to the workflow design
that currently exists in the prototype.
- Add these buttons to the top and bottom of the page, as submit buttons
  on a form that POSTs to the current URL
- Rework RecordMedicalInformationForm to back these forms, and have its
  save function create all missing medical info review records for the
  appointment
- Have the view wrap the save call to this form in a transaction (as
  we're potentially writing multiple database records)
- Redirect to Awaiting Images when done
@malcolmbaig malcolmbaig requested a review from a team as a code owner December 24, 2025 11:53
Change assertions which depended on a previous design of the review
medical information page.
@sonarqubecloud
Copy link

Copy link
Contributor

@carlosmartinez carlosmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malcolmbaig malcolmbaig merged commit 8f9a89e into main Dec 29, 2025
14 checks passed
@malcolmbaig malcolmbaig deleted the 11591-med-info-complete-all-continue branch December 29, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants