Remove duplicated UserFactory #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
approved these changes
Jan 7, 2026
MatMoore
requested changes
Jan 8, 2026
Contributor
MatMoore
left a comment
MatMoore
left a comment
There was a problem hiding this comment.
The model is defined in auth so can you move the factory there or keep that one instead?
* remove manage_breast_screening/auth/tests/factories.py * move manage_breast_screening/clinic/tests/factories.py UserFactory to manage_breast_screening/user as it the model is defined there * fix failing tests that expected email = "" by setting that explicitly We had two slightly different definitions of UserFactory both arguably in the wrong place. Move to the correct place.
gpeng
force-pushed
the
remove-duplicate-user-factory-definition
branch
from
a22f072 to
83e0d7b
Compare
|
Contributor
Author
|
Our |
MatMoore
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove manage_breast_screening/auth/tests/factories.pyupdate imports to use the clinics versionWe had two slightly different definitions of UserFactory. The removed one didn't generate an email by default so switching to the manage_breast_screening/clinics/tests/factories.py required some tests to be fixed.
Review notes
No behavioural change. Just a tidy up.