Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

@ianfnelson
Copy link
Contributor

@ianfnelson ianfnelson commented Jun 2, 2025

Description

Performs file-level validation of NBSS Appointment Event files, covering the following validation rules:

  • NBSSAPPT002 - Header is missing
  • NBSSAPPT003 - Extract ID is missing
  • NBSSAPPT004 - Extract ID is in an invalid format
  • NBSSAPPT005 - Record count is missing
  • NBSSAPPT006 - Record count is in an invalid format
  • NBSSAPPT007 - Trailer is missing
  • NBSSAPPT008 - Extract ID does not match value in header
  • NBSSAPPT009 - Record count does not match value in header
  • NBSSAPPT011 - Record count does not match value in header and trailer

Context

Acts as an anti-corruption layer at the point of ingress to NSP.
Ensures quality of data, guards against coding errors by both parties.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ianfnelson ianfnelson force-pushed the feat/DTOSS-9159-file-level-validation branch from 999ef40 to a5f0c20 Compare June 3, 2025 07:47
@ianfnelson ianfnelson marked this pull request as ready for review June 3, 2025 07:51
@ianfnelson ianfnelson added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 0593b4f Jun 3, 2025
26 checks passed
@ianfnelson ianfnelson deleted the feat/DTOSS-9159-file-level-validation branch June 3, 2025 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants