Skip to content

Chore: [AEA-6070] - Add Unit Tests #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kieran-wilkinson-4 merged 26 commits into from
Dec 23, 2025
Merged

Chore: [AEA-6070] - Add Unit Tests #240

kieran-wilkinson-4 merged 26 commits into from
Dec 23, 2025

Conversation

@kieran-wilkinson-4
Copy link
Contributor

@kieran-wilkinson-4 kieran-wilkinson-4 commented Dec 15, 2025 •
edited
Loading

Summary

Adds unit tests for handling citations within AI reponses

Details

  • Splits slack_event tests into "message", "event", and "citation" for easier navigation
  • Add tests for add citations
  • Add tests for handling formatting within messages and citations

@github-actions
Copy link

github-actions bot commented Dec 15, 2025 •
edited
Loading

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-6070

@kieran-wilkinson-4 kieran-wilkinson-4 force-pushed the AEA-6070-Update-Unit-Tests-Coverage branch from 45ded80 to 2b605d0 Compare December 17, 2025 16:55
@kieran-wilkinson-4 kieran-wilkinson-4 changed the title feat: Add tests for opening, closing and changing citations Chore: [AEA-6070] - Add Unit Tests Dec 19, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kieran-wilkinson-4 kieran-wilkinson-4 enabled auto-merge (squash) December 23, 2025 14:31
bencegadanyi1-nhs
bencegadanyi1-nhs approved these changes Dec 23, 2025
View reviewed changes
packages/slackBotFunction/app/services/prompt_loader.py

logger.info(
f"Loading prompt {prompt_name}' (ID: {prompt_id})",
extra={"prompt_name": prompt_name, "prompt_id": prompt_id, "prompt_version": prompt_version},
Copy link
Contributor

@bencegadanyi1-nhs bencegadanyi1-nhs Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): i'd probably keep the prompt_name and prompt_id extras so that we can search for them in the logs

Copy link
Contributor Author

@kieran-wilkinson-4 kieran-wilkinson-4 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already in the name

@kieran-wilkinson-4 kieran-wilkinson-4 merged commit 1391ff7 into main Dec 23, 2025
12 checks passed
@kieran-wilkinson-4 kieran-wilkinson-4 deleted the AEA-6070-Update-Unit-Tests-Coverage branch December 23, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencegadanyi1-nhs bencegadanyi1-nhs bencegadanyi1-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kieran-wilkinson-4 @bencegadanyi1-nhs