fix(data-migration): FTRS-1485 Resolve ETL End-To-End Testing Issues #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomdango
force-pushed
the
task/FTRS-1485-fix-etl-end-to-end
branch
from
b61052b to
d99e2e0
Compare
Tomdango
temporarily deployed
to
dev-protected
GitHub Actions
Inactive
prjh2-nhs
reviewed
Nov 19, 2025
Contributor
prjh2-nhs
left a comment
prjh2-nhs
left a comment
There was a problem hiding this comment.
nice PR 😎 (just one comment 🧐)
| raise ValueError( | ||
| "Invalid DataMigrationConfig: db_config.connection_string must be a non-empty string" | ||
| ) | ||
| self.engine = create_engine(connection_string, echo=False) |
Contributor
There was a problem hiding this comment.
For the "Recreate Legacy Service Model to remove SQLAlchemy tracking" in ticket, mentions:
- "
postgresql_readonlyexecution option should be added to the database connection to ensure any update interactions are immedately rejected by the database to prevent this issue from being reintroduced."
^ would that be here? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.