-
Notifications
You must be signed in to change notification settings - Fork 3
VED-981 Add base infrastructure for the MNS Publisher feature #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VED-981 Add base infrastructure for the MNS Publisher feature #1191
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-981 |
|
| policy = data.aws_iam_policy_document.mns_outbound_events_sqs_policy.json | ||
| } | ||
|
|
||
| # TODO - (follow on once we have basics set up so Lambda coding can start) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless strong objections - and happy to do it in this PR if required - I would propose merging this PR in, subject to approval, as-is so that Lambda function code can be worked on in parallel.
Someone can then pick up the remaining bits of platform changes, but it allows us to at least set up the foundations on the staging branch if we merge asap.
Namely, I think the remaining changes would include:
- KMS encryption for SQS since the data will include PID
- Add DLQ and redrive settings for the outbound mns events queue
- Optional - turn the relevant components into a single mns_publisher module.
- Optional - (might wanna agree testing approach first) add a switch so this feature is only toggled on in environments we want it. May also need to create a test queue for testing that published events are actually broadcast and received by subscribers.
edhall-nhs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution. Good to see it working as well 🎉
Agree that those TODOs can be worked on in parallel with the lambda implementation
33f4bba
into
staging/VED-16-mns-vacc-event-notifications



Summary
Simple architecture change to enable coding work to begin on the Lambda. Details of the ticket are no longer relevant, so will update in JIRA. Discussed with architect who was happy with the changes.
This approach minimises the number of new components we will need while ensuring that we are only publishing MNS events where the event was successfully persisted across the whole system i.e. the events table and delta.
Have raised a couple of questions, which I'm happy to look into under this PR or
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.