-
Notifications
You must be signed in to change notification settings - Fork 3
VED-000 staging test build #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
JamesW1-NHS
wants to merge
11
commits into
staging/VED-508-validation-refactor-and-dq-feature
from
VED-000-staging-test
Closed
VED-000 staging test build #998
JamesW1-NHS
wants to merge
11
commits into
staging/VED-508-validation-refactor-and-dq-feature
from
VED-000-staging-test
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…980) * Bump @redocly/cli from 2.11.0 to 2.11.1 in the npm-minor-patch group Bumps the npm-minor-patch group with 1 update: [@redocly/cli](https://github.com/Redocly/redocly-cli). Updates `@redocly/cli` from 2.11.0 to 2.11.1 - [Release notes](https://github.com/Redocly/redocly-cli/releases) - [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@2.11.0...@redocly/cli@2.11.1) --- updated-dependencies: - dependency-name: "@redocly/cli" dependency-version: 2.11.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Trigger Build --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>
* init: move recordforwarder, copy src/models
* temp: sonar.cpd.exclusions
* nosonar
* temp: sonar.exclusions
* test: remove Dockerfile path
* test: remove Dockerfile path II
* test: remove Dockerfile path III
* fix source_path
* lint
* init: move batch source and tests, duplicate testing_utils
* backend -> lambdas
* cleanup docker tags
* sonar
* lambdas/backend
* sonar
* source_path
* clients/redis_client
* errors
* ruff
* shared/src/common/models
* TEMP: sonar exclusions
* TEMP: sonar exclusions II
* ruff
* cache
* interim - for merge
* interim - for merge II
* path fix
* backend tests
* ruff
* poetry.lock
* smells
* smell: pydantic.ValidationError
* smell: expression_attribute_values
* ApiValidationError
* errors / api_errors
* errors / api_errors II
* backend -> shared
* :${{ env.SHARED_PATH }}/tests
* recordforwarder -> shared
* sonar
* S5332
* smells
* smells II
* smells III
* constants
* ruff
* errors
* rest of errors
* ruff
* singleton s3 client
* shared s3 client II
* mesh_processor env
* assert bug fix attempt
* move_file
* move_file II
* reworked test_clients
* bucket cleanup
* get_nhs_number
* make_*_pk
* make_*_pk II
* cleanup
* remove cpd.exclusions
* utils -> aws_s3_utils
* backend/src/constants
* backend/src/constants II
* utils -> aws_s3_utils II
* remove PII
* revert PK stuff from generic_utils
* Add Optum FLU permission in non prod envs. * Add all vaccine type permissions for RAVS in non prod.
* docs: search immunisation by identifier * create new schema and relative 4XX responses
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-000 |
|
Contributor
Author
|
PoC closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


WIP only. To check that staging builds normally including e2e.
Trying to track down why it doesn't build in #996 - is it staging, moving of folders, or the validator?
Answer: It was the validator. Or rather, it was because the validator attempts to get the schema from redis, and it isn't there. I think we would have to modify the terraform to put it in there in the first place.