Merged
Conversation
Modalities will likely need SCHEDULED and IN PROGRESS items at the very least. Defaulting to SCHEDULED may obscure items. Remove the status clause, we can implement this as a query parameter.
steventux
force-pushed
the
fix/remove-c-find-status-clause
branch
from
745d71a to
4d34a1a
Compare
| ) | ||
|
|
||
| logger.info(f"Found {len(items)} matching worklist items") | ||
| logger.info("Found %s matching worklist items", len(items)) |
Contributor
There was a problem hiding this comment.
y u hate fstrings so much?
Contributor
Author
There was a problem hiding this comment.
It's a (very) minor optimisation. If the log statement in question is not called (ie the log level is higher) then the string interpolation does not occur. Whereas with fstring interpolation is implicit.
IIRC there is a Python linter somewhere that enforces this.
Contributor
There was a problem hiding this comment.
ah well, if we're saving the planet than i approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
C-FINDshould not implicitly filter worklist items that are notSCHEDULEDbut this is currently the default.There's no mention of filtering by status with
C-FINDquery identifiers.See https://dicom.nema.org/dicom/2013/output/chtml/part04/sect_K.6.html#table_K.6-1 where attributes like Modality have notes like The Modality shall be retrieved with Single Value Matching. there is no retrieval note for
ScheduledProcedureStepStatus.This PR removes the query clause.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12237
Review notes
Review checklist