-
Notifications
You must be signed in to change notification settings - Fork 3
Automatic images – troubleshooting expander and content #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rivalee
commented
Dec 24, 2025
- Add troubleshooting content within an expander to automatic images pages
| {% include "_includes/images/image-troubleshooting.njk" %} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like this might be better placed above.
| <div class="nhsuk-button-group nhsuk-u-margin-bottom-0"> | ||
| {{ button({ | ||
| text: "Re-scan PACS for image updates", | ||
| classes: "nhsuk-button--secondary" | ||
| }) }} | ||
|
|
||
| <a class="nhsuk-link app-link--error" href="#">There is a problem with the images</a> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section likely wants to be replaced with your new expander?
| {{ button({ | ||
| text: "Resend images from mammogram machine", | ||
| href: "#", | ||
| classes: "app-button--small" | ||
| }) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better as secondary button? regular size too?
| classes: "app-button--small" | ||
| }) }} | ||
|
|
||
| <p>or</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about semantics of a paragraph like this.
|
|
||
| <p>or</p> | ||
|
|
||
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somewhat feel we should actively record that there has been a fault and ask what the fault was. As it is we don't really know what's gone wrong - just that they've used the manual flow.
|
|
||
| <p>or</p> | ||
|
|
||
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p> | |
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected.</p> |
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p> | ||
|
|
||
| <h2>Technical issues with the mammogram machine</h2> | ||
| <p><a href="./attended-not-screened-reason" class="nhsuk-link app-link--warning">Stop this appointment</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I'm not sure we can link to attended-not-screened - you shouldn't get ANS status if we've taken images - which is more likely by this point.
If this include is shown from the images-automatic page, then we think we have images. If it's shown on the prior page we might still have images.
We perhaps need a new dedicated end page? Asks if any images were taken and details of what went wrong?
| {{ button({ | ||
| text: "Resend images from mammogram machine", | ||
| href: "#", | ||
| classes: "app-button--small" | ||
| }) }} | ||
|
|
||
| <p>or</p> | ||
|
|
||
| <p><a href="./images-manual" class="nhsuk-link">Record image information manually</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing between the button, 'or', and link feels uneven.
|
|
||
| {% include "_includes/images/image-troubleshooting.njk" %} | ||
|
|
||
| {% include "screening-cannot-proceed-link.njk" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to think about this link. Is it still needed if we have the troubleshooting expander? Perhaps the expander needs a section about needing to stop prior to taking images (that can lead to the attended not screened page).
| {% from "details/macro.njk" import details %} | ||
| {% from "button/macro.njk" import button %} | ||
|
|
||
| <div class="nhsuk-expander-group"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only needed where there are multiple expanders grouped together.