Skip to content

Conversation

@rivalee
Copy link
Collaborator

@rivalee rivalee commented Dec 24, 2025

  • Add troubleshooting content within an expander to automatic images pages

Comment on lines +204 to +205
{% include "_includes/images/image-troubleshooting.njk" %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like this might be better placed above.

Comment on lines 133 to 140
<div class="nhsuk-button-group nhsuk-u-margin-bottom-0">
{{ button({
text: "Re-scan PACS for image updates",
classes: "nhsuk-button--secondary"
}) }}

<a class="nhsuk-link app-link--error" href="#">There is a problem with the images</a>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section likely wants to be replaced with your new expander?

Comment on lines +17 to +21
{{ button({
text: "Resend images from mammogram machine",
href: "#",
classes: "app-button--small"
}) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better as secondary button? regular size too?

classes: "app-button--small"
}) }}

<p>or</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about semantics of a paragraph like this.


<p>or</p>

<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat feel we should actively record that there has been a fault and ask what the fault was. As it is we don't really know what's gone wrong - just that they've used the manual flow.


<p>or</p>

<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p>
<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected.</p>

<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a> – you can add notes to indicate what information needs to be corrected</p>

<h2>Technical issues with the mammogram machine</h2>
<p><a href="./attended-not-screened-reason" class="nhsuk-link app-link--warning">Stop this appointment</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I'm not sure we can link to attended-not-screened - you shouldn't get ANS status if we've taken images - which is more likely by this point.

If this include is shown from the images-automatic page, then we think we have images. If it's shown on the prior page we might still have images.

We perhaps need a new dedicated end page? Asks if any images were taken and details of what went wrong?

Comment on lines +17 to +25
{{ button({
text: "Resend images from mammogram machine",
href: "#",
classes: "app-button--small"
}) }}

<p>or</p>

<p><a href="./images-manual" class="nhsuk-link">Record image information manually</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing between the button, 'or', and link feels uneven.


{% include "_includes/images/image-troubleshooting.njk" %}

{% include "screening-cannot-proceed-link.njk" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to think about this link. Is it still needed if we have the troubleshooting expander? Perhaps the expander needs a section about needing to stop prior to taking images (that can lead to the attended not screened page).

{% from "details/macro.njk" import details %}
{% from "button/macro.njk" import button %}

<div class="nhsuk-expander-group">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only needed where there are multiple expanders grouped together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants