[PRM-562] ProductionSupport IAM policy for targeted Admin access #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbloe
had a problem deploying
to
development
GitHub Actions
Failure
chrisbloe
had a problem deploying
to
development
GitHub Actions
Failure
samfallowfield
temporarily deployed
to
development
GitHub Actions
Inactive
samfallowfield
previously approved these changes
Oct 27, 2025
chrisbloe
had a problem deploying
to
development
GitHub Actions
Failure
|
Report for environment: ndr-devTerraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new IAM policy which will be attached to a new specific role (
ProductionSupport) and made available in Production only - the purpose of this policy is to define a restricted set of permissions to enable specific tasks... the first of which is AWS Transfer Family management. If new tasks are defined later, this policy could be extended to support them (though I am not adverse to having this policy just for this task and creating other policies/roles to support future tasks, if that is preferred by the group).Whilst I'm comfortable with the S3 permissions, the Transfer Family part is less clear - I'm not expecting this to work first time without intervention, but getting something into prod that we can work will will allow us to tweak it until it works as we want.
Crucially, I think the new
ProductionSupportrole should not have fullReadOnlyAccess, instead, I see this role as only having access to what is needed to perform its function - that way, we're not giving full read access to PID etc. unnecessarily.