Skip to content

[NDR-365] Allow title to be optional #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
megan-bower4 wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[NDR-365] Allow title to be optional #1008

megan-bower4 wants to merge 11 commits into from

Conversation

@megan-bower4
Copy link
Contributor

@megan-bower4 megan-bower4 commented Jan 22, 2026 •
edited
Loading

Overview

Jira ticket: NDR-365

Description

Context

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits.
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@megan-bower4 megan-bower4 marked this pull request as ready for review February 5, 2026 09:30
@megan-bower4 megan-bower4 requested review from a team as code owners February 5, 2026 09:30
@chrisbloe chrisbloe changed the title NDR-365 Allow title to be optional [NDR-365] Allow title to be optional Feb 5, 2026
@megan-bower4 megan-bower4 force-pushed the NDR-365 branch 2 times, most recently from ae88fd6 to 3bf7b14 Compare February 5, 2026 12:11
jameslinnell
jameslinnell reviewed Feb 6, 2026
View reviewed changes
NogaNHS
NogaNHS reviewed Feb 11, 2026
View reviewed changes
lambdas/tests/e2e/api/fhir/test_upload_document_fhir_api_success.py
assert field not in doc_ref["Item"]["RawRequest"]


def test_create_document_without_title(test_data):
Copy link
Contributor

@NogaNHS NogaNHS Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this text to make it clear this is only for PATIENT_DATA snomed code?

Copy link
Contributor Author

@megan-bower4 megan-bower4 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the tests within the fhir folder (tests/e2e/api/fhir) are for PATIENT_DATA only, and the level above (tests/e2e/api) cover the Lloyd George use case. This is generated from the corresponding data helper function (so all the tests in this file for example use that snomed code only).

I think this would be useful to add to the readme though - I'm working on a test review ticket now so as part of that I can update the readme to make it clearer which snomed codes are being tested/expected :)

NogaNHS
NogaNHS previously approved these changes Feb 11, 2026
View reviewed changes
@megan-bower4 megan-bower4 dismissed stale reviews from jameslinnell and NogaNHS via 296349b February 11, 2026 12:20
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 11, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameslinnell jameslinnell jameslinnell approved these changes

@NogaNHS NogaNHS NogaNHS left review comments

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@megan-bower4 @jameslinnell @NogaNHS