Skip to content

[PRMP-1208] content change error message #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SWhyteAnswer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[PRMP-1208] content change error message #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b7d8a3
[PRMP-1208] content change error message
SWhyteAnswer Feb 9, 2026
87a643e
[PRMP-1208]reverting removing second error message
SWhyteAnswer Feb 9, 2026
4b2c87a
[PRMP-1208] tests
SWhyteAnswer Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...ts/blocks/_admin/reviewDetailsPatientSearchStage/ReviewDetailsPatientSearchStage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,29 @@ describe('ReviewDetailsPatientSearchPage', () => {
});
});

it('displays incorrectFormatMessage in both ErrorBox and TextInput on validation failure', async () => {
render(
<ReviewDetailsPatientSearchStage
uploadDocuments={[]}
reviewData={mockReviewData}
setNewPatientDetails={(): void => {}}
/>,
);

const input = screen.getByTestId('nhs-number-input');
const continueButton = screen.getByTestId('continue-button');

// Submit with invalid NHS number
await userEvent.type(input, '12345');
await userEvent.click(continueButton);

await waitFor(() => {
// Check that incorrectFormatMessage appears twice (ErrorBox + TextInput)
const errorMessages = screen.getAllByText(incorrectFormatMessage);
expect(errorMessages).toHaveLength(2);
});
});

it('shows error for invalid NHS number format', async () => {
render(
<ReviewDetailsPatientSearchStage
Expand Down
7 changes: 4 additions & 3 deletions ...ponents/blocks/_admin/reviewDetailsPatientSearchStage/ReviewDetailsPatientSearchStage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ import { DOWNLOAD_STAGE } from '../../../../types/generic/downloadStage';
import { getFormattedDateFromString } from '../../../../helpers/utils/formatDate';
import { ReviewUploadDocument } from '../../../../types/pages/UploadDocumentsPage/types';

export const incorrectFormatMessage = "Enter patient's 10 digit NHS number";
export const incorrectFormatMessage =
"Enter a valid patient NHS number. If you keep getting this message, select 'I don't know the NHS number'.";
Copy link
Contributor

@NogaNHS NogaNHS Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

Copy link
Contributor Author

@SWhyteAnswer SWhyteAnswer Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


interface ReviewDetailsPatientSearchPageProps {
reviewData: ReviewDetails | null;
Expand Down Expand Up @@ -159,6 +160,8 @@ const ReviewDetailsPatientSearchStage = ({
<>
<BackButton backLinkText="Go back" dataTestid="back-button" />

<h1>Search for the correct patient</h1>

{(submissionState === PATIENT_SEARCH_STATES.FAILED ||
inputError === incorrectFormatMessage) && (
<>
Expand All @@ -175,8 +178,6 @@ const ReviewDetailsPatientSearchStage = ({
</>
)}

<h1>Search for the correct patient</h1>

<p>Enter the NHS number to find the correct patient demographics for this document.</p>

<form onSubmit={handleSubmit(handleValidSubmit, handleFormError)}>
Expand Down
Loading