Skip to content

[NDR-363] Search by default will only return NON-DELETED docs #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jameslinnell wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[NDR-363] Search by default will only return NON-DELETED docs #1070

jameslinnell wants to merge 10 commits into from
+177 −40

Conversation

@jameslinnell
Copy link
Contributor

@jameslinnell jameslinnell commented Feb 10, 2026 •
edited
Loading

Overview

Jira ticket: NDR-363

Description

By default Search returns all items if no filters are used. This now does not return deleted items.

Context

We don't want deleted items by default in search results.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits.
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@jameslinnell jameslinnell requested review from a team as code owners February 10, 2026 15:01
megan-bower4
megan-bower4 reviewed Feb 10, 2026
View reviewed changes
megan-bower4
megan-bower4 reviewed Feb 10, 2026
View reviewed changes
megan-bower4
megan-bower4 previously approved these changes Feb 11, 2026
View reviewed changes
matthewpotter2-nhs
matthewpotter2-nhs reviewed Feb 11, 2026
View reviewed changes
lambdas/services/document_reference_search_service.py Outdated
@@ -124,14 +128,11 @@ def _search_tables_for_documents(
return document_resources or None

def _get_filter_expression(
Copy link
Contributor

@matthewpotter2-nhs matthewpotter2-nhs Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this method not just be replaced? or the _build_filter_expression method?

megan-bower4
megan-bower4 previously approved these changes Feb 11, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewpotter2-nhs matthewpotter2-nhs matthewpotter2-nhs left review comments

@megan-bower4 megan-bower4 megan-bower4 approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslinnell @matthewpotter2-nhs @megan-bower4