[PRMP-1384] File integrity check in document upload process #1075
+633
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwhitingnhs
temporarily deployed
to
development
GitHub Actions
Inactive
…dencies - Implement check for locked or corrupt files during document upload process. - Introduce new INVALID status for documents that are password protected or corrupted. - Create requirements for files_lambda_layer to include msoffcrypto-tool.
adamwhitingnhs
temporarily deployed
to
development
GitHub Actions
Inactive
Code security issues foundView full details here. |
|
kamenbachvarov-nhs
approved these changes
Feb 11, 2026
SWhyteAnswer
approved these changes
Feb 11, 2026
lillie-dae
approved these changes
Feb 11, 2026
|
|
||
| def get_object_stream(self, bucket: str, key: str): | ||
| response = self.client.get_object(Bucket=bucket, Key=key) | ||
| def get_object_stream(self, bucket: str, key: str, byte_range: str = None): |
Contributor
There was a problem hiding this comment.
byte_range: str | None = None
| if doc_ref.doc_status == "cancelled": | ||
| if doc_ref.virus_scanner_result == VirusScanResult.INFECTED: | ||
| return DocumentStatus.INFECTED.display, DocumentStatus.INFECTED.code | ||
| elif doc_ref.virus_scanner_result == VirusScanResult.INVALID: |
Contributor
There was a problem hiding this comment.
can probably just be
if doc_ref.virus....... instead of elif
| assert result["doc-id-4"]["error_code"] == DocumentStatus.INFECTED.code | ||
|
|
||
|
|
||
| def test_get_document_references_by_id_invalid_document( |
Contributor
There was a problem hiding this comment.
Could be a good idea to include some e2e tests for this scenario
| ) | ||
| mock_stream.read.assert_called_once_with() | ||
| mock_bytesio.assert_called_once_with(file_content) | ||
| mock_check.assert_called_once_with(mock_file_stream, file_extension) |
Contributor
There was a problem hiding this comment.
Maybe some more tests here that include failure scenarios.
file_name missing/None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-1384
Description
Context
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC