[PRMP-908] Refactor MNS document review logic and handling #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleandersonNHS
previously requested changes
Dec 8, 2025
Contributor
danielleandersonNHS
left a comment
danielleandersonNHS
left a comment
There was a problem hiding this comment.
Couple of comments to address/consider
…ice to use centralised error messages
jameslinnell
reviewed
Dec 9, 2025
jameslinnell
reviewed
Dec 9, 2025
jameslinnell
reviewed
Dec 9, 2025
Contributor
|
Checklist number 5 should not have a strikethrough as there are changes here that have an affect on the Core. Also it's unecessary to strike it through as it's a question about whether you have thought about the other team. If if there is no affect to the other team the answer to that question should still be yes. |
Contributor
|
Sorry, didn't mean to close that. Pressed the wrong button. |
chrisbloe
changed the title
# Conflicts: # lambdas/enums/document_review_status.py # lambdas/models/document_review.py # lambdas/services/document_service.py # lambdas/services/document_upload_review_service.py # lambdas/tests/unit/services/test_document_upload_review_service.py # lambdas/utils/exceptions.py
… improve error handling
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
…test for improved clarity and functionality
steph-torres-nhs
previously approved these changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
is it worth using the models here to create respective dynamodb entries?
# Conflicts: # lambdas/enums/document_review_status.py # lambdas/enums/lambda_error.py # lambdas/tests/unit/services/test_document_upload_review_service.py
NogaNHS
had a problem deploying
to
development
GitHub Actions
Failure
# Conflicts: # lambdas/services/document_service.py # lambdas/services/document_upload_review_service.py # lambdas/tests/unit/services/test_document_upload_review_service.py
Code security issues foundView full details here. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-908
Description
Refactored and improved the mns service with document review logic with better handling.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)I have updated relevant documentation.SANDBOX Full- Deploy feature branch to sandbox- workflow run - 19959318708