[PRMP-1079] Dynamodb query limit doesn't work as expected. #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
reviewed
Dec 18, 2025
NogaNHS
reviewed
Dec 18, 2025
Comment on lines
93
to
106
| response = self.dynamo_service.query_table_with_paginator( | ||
| table_name=self.table_name, | ||
| index_name="CustodianIndex", | ||
| key="Custodian", | ||
| condition=ods_code, | ||
| filter_expression=filter_expression, | ||
| expression_attribute_names=condition_attribute_names, | ||
| expression_attribute_values=condition_attribute_values, | ||
| start_key=start_key, | ||
| limit=limit, | ||
| ) | ||
|
|
||
| references = self._validate_review_references(response["Items"]) | ||
| last_evaluated_key = response.get("NextToken") |
Contributor
There was a problem hiding this comment.
I wonder if this should be in DocumentService
NogaNHS
reviewed
Dec 18, 2025
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
reviewed
Dec 19, 2025
| filter_expression, condition_attribute_names, condition_attribute_values = ( | ||
| self.build_paginator_query_filter(nhs_number=nhs_number, uploader=uploader) | ||
| ) | ||
| response = self.dynamo_service.query_table_with_paginator( |
kamenbachvarov-nhs
previously approved these changes
Dec 19, 2025
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-1079
Description
Find another method of returning the expected number of results using a limit and pagination when querying dynamodb
Context
Using a limit along side a filter expression within a dynamodb query doesn't return the number of results as initially expected, the filter is applied after the limit.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)[ ] 4. I have updated relevant documentation.Deploy - Sandbox- workflow run - 20331224066-
[ ] 6b.SANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC