Skip to content

Conversation

@steph-torres-nhs
Copy link
Contributor

Overview

Jira ticket: PRMP-1158

Description

Removal of checking file is in the expected location before scanning for viruses.

Context

On uploading new files for review, when a new entry is created in the document pending review table a file location is not set on the object as it is unknown whether the upload via CloudFront will have happened successfully. The virus scan check process checks for an expected file location and is unable to find anything and so the lambda fails, meaning the object is neither scanned nor moved from staging to review bucket.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • [] 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant