[PRMP-975] Document Search Results Backend - Pagination #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

adamwhitingnhs merged 39 commits into main from PRMP-975

Feb 12, 2026

Contributor

steph-torres-nhs commented Jan 13, 2026 •

edited

Loading

Overview

Jira ticket: PRMP-975

Description

Adding pagination capability to Document Reference Search

Context

Checklist

Tasks for all changes:

1. I have linked this PR to its Jira ticket.
2. ~~I have run git pre-commits.~~ (WIP)
3. I have added and/or updated relevant tests.
~~[ ] 4. I have updated relevant documentation.~~
5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:
- 6a. Deploy - Sandbox - workflow run: PRMP-975
- 6b. SANDBOX Full- Deploy feature branch to sandbox - workflow run

steph-torres-nhs added 13 commits

January 6, 2026 10:10


          [PRMP-975] add util to extract relevant querystring params

0904a5b


          [PRMP-975] remove functionality of searching multiple tables

d6a88c5


          Merge branch 'main' into PRMP-975

e7d8076


          [PRMP-975] extract limit from querystring

0aae733


          [PRMP-975] add pagination to doc ref search service

65e3deb


          [PRMP-975] add query with pagination to doc ref search

50a322b


          [PRMP-975] amend how filter is handled

44d0f47


          [PRMP-975] update lg dynamo mock response

ed30447


          [PRMP-975] update lg dynamo mock response

7ff97f9


          [PRMP-975] add filter build helper

45ce75d


          [PRMP-975] camelize response

21135cd


          [PRMP-975] add test

47520bb


          Merge branch 'main' into PRMP-975

a360b9e

steph-torres-nhs had a problem deploying to development

January 13, 2026 14:42

— with

GitHub Actions Failure

NogaNHS reviewed

View reviewed changes

lambdas/tests/unit/services/test_get_fhir_document_reference_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/handlers/document_reference_search_handler.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/handlers/document_reference_search_handler.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/document_reference_search_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/document_reference_search_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/document_reference_search_service.py Outdated Show resolved Hide resolved

NogaNHS reviewed

View reviewed changes

lambdas/services/document_reference_search_service.py Outdated Show resolved Hide resolved

steph-torres-nhs added 2 commits

January 14, 2026 11:51


          [PRMP-975] address PR comments

0968a90


          [PRMP-975] format

402ac05

steph-torres-nhs had a problem deploying to development

January 14, 2026 11:57

— with

GitHub Actions Failure


          [PRMP-975] adjust filter expression

f86d414

steph-torres-nhs had a problem deploying to development

January 14, 2026 14:30

— with

GitHub Actions Failure


          [PRMP-975] change getDocSearchResults response object

887bebb

steph-torres-nhs had a problem deploying to development

January 15, 2026 16:00

— with

GitHub Actions Failure


          [PRMP-975] check 204 response, upload complete filter

e3f19ed

steph-torres-nhs had a problem deploying to development

January 16, 2026 11:40

— with

GitHub Actions Failure

steph-torres-nhs temporarily deployed to development

February 9, 2026 11:54

— with

GitHub Actions Inactive


          Merge branch 'main' into PRMP-975

322cfd3

steph-torres-nhs temporarily deployed to development

February 9, 2026 13:53

— with

GitHub Actions Inactive

lillie-dae previously approved these changes

View reviewed changes


          Merge branch 'main' into PRMP-975

9916cc1

steph-torres-nhs temporarily deployed to development

February 10, 2026 14:46

— with

GitHub Actions Inactive


          [PRMP-975] format

c8b62bd

steph-torres-nhs dismissed lillie-dae’s stale review via

c8b62bd

February 10, 2026 14:47

steph-torres-nhs temporarily deployed to development

February 10, 2026 14:47

— with

GitHub Actions Inactive

adamwhitingnhs previously approved these changes

View reviewed changes


          [PRMP-975] merge in main, resolve conflicts, format

4a1f8fd

steph-torres-nhs dismissed adamwhitingnhs’s stale review via

4a1f8fd

February 11, 2026 09:41

steph-torres-nhs temporarily deployed to development

February 11, 2026 09:41

— with

GitHub Actions Inactive

lillie-dae previously approved these changes

View reviewed changes

adamwhitinganswer previously approved these changes

View reviewed changes

adamwhitingnhs previously approved these changes

View reviewed changes

adamwhitingnhs dismissed adamwhitinganswer’s stale review

February 11, 2026 11:11

invalid


          Merge branch 'main' into PRMP-975

aa1507a

DuncanSangsterNHS temporarily deployed to development

February 11, 2026 16:01

— with

GitHub Actions Inactive


          [PRMP-975] merge main resolve conflicts

675ade3

steph-torres-nhs dismissed stale reviews from lillie-dae and adamwhitingnhs via

675ade3

February 12, 2026 10:37

steph-torres-nhs temporarily deployed to development

February 12, 2026 10:37

— with

GitHub Actions Inactive

github-actions bot commented Feb 12, 2026

Code security issues found

View full details here.

adamwhitingnhs approved these changes

View reviewed changes

adamwhitingnhs enabled auto-merge (squash)

February 12, 2026 10:41

sonarqubecloud bot commented Feb 12, 2026

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

NogaNHS approved these changes

View reviewed changes

adamwhitingnhs merged commit af2ff9b into main

30 of 31 checks passed

adamwhitingnhs deleted the PRMP-975 branch

February 12, 2026 10:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jameslinnell jameslinnell left review comments

NogaNHS NogaNHS approved these changes

adamwhitingnhs adamwhitingnhs approved these changes

lillie-dae lillie-dae left review comments

SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

+1 more reviewer

adamwhitinganswer adamwhitinganswer left review comments

Labels

None yet