Skip to content

Conversation

@ste-banks
Copy link
Contributor

@ste-banks ste-banks commented Dec 16, 2025

Description

We need to persist the updated session when hitting the 'go back' button in the journey but as the change session uplift journey doesn't use the wizard, I've had to implement this using session storage instead. The item will be removed upon submission of the session edit OR if going back as far as the edit session decision page. Existing unit tests have been updated to ensure the remove/set/get session storage methods get called where relevant.

The long term fix for this would be to refactor the change session uplift journey (and the cancel session uplift journey) to use the wizard steps but that change is too big to sort this bug fix out and we've had a number of issues around both of these recently, hence resorting to using session storage instead.

Fixes # (issue)

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@ste-banks ste-banks changed the title Persist the new session info when going back in the uplift journey APPT-1663 - Persist the new session info when going back in the uplift journey Dec 17, 2025
@ste-banks ste-banks marked this pull request as ready for review December 17, 2025 11:33
@sonarqubecloud
Copy link

@ste-banks ste-banks merged commit 0387f37 into main Jan 2, 2026
3 checks passed
@ste-banks ste-banks deleted the appt-1663/persist-updated-session-info branch January 2, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants