Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/merge-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.repository == 'NHSDigital/nhs-aws-helpers' && !contains(github.event.head_commit.message, 'tag release version:')
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:

- name: code coverage report
if: ${{ github.event_name == 'pull_request' }}
uses: orgoro/coverage@c65003f41276ea33fe3a3a5d53df8b340462e8fa
uses: orgoro/coverage@7dbd48c7f7ed09df337ff40058340c85bc93cb3d
with:
coverageFile: reports/coverage.xml
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
if: github.repository == 'NHSDigital/nhs-aws-helpers' && github.actor != 'dependabot[bot]' && !contains(github.event.head_commit.message, 'tag release version:')
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand Down
58 changes: 32 additions & 26 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ permissions:
pull-requests: write

jobs:

tox:
strategy:
matrix:
Expand All @@ -18,7 +17,7 @@ jobs:
if: github.repository == 'NHSDigital/nhs-aws-helpers'
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand All @@ -37,11 +36,14 @@ jobs:
- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
git checkout "${{ github.base_ref }}"
echo base branch "$BASE_BRANCH"
echo pr branch "$PR_BRANCH"
git checkout "$BASE_BRANCH"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
env:
BASE_BRANCH: ${{ github.base_ref }}
PR_BRANCH: ${{ github.head_ref }}

- name: setup python
uses: actions/setup-python@v5
Expand All @@ -61,13 +63,12 @@ jobs:
if: success() || failure()
run: make down


coverage:
runs-on: ubuntu-latest
if: github.repository == 'NHSDigital/nhs-aws-helpers'
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand All @@ -89,11 +90,14 @@ jobs:
- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
git checkout "${{ github.base_ref }}"
echo base branch "$BASE_BRANCH"
echo pr branch "$PR_BRANCH"
git checkout "$BASE_BRANCH"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
env:
BASE_BRANCH: ${{ github.base_ref }}
PR_BRANCH: ${{ github.head_ref }}

- name: setup python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -133,7 +137,7 @@ jobs:

- name: code coverage report
if: ${{ github.event_name == 'pull_request' }}
uses: orgoro/coverage@c65003f41276ea33fe3a3a5d53df8b340462e8fa
uses: orgoro/coverage@7dbd48c7f7ed09df337ff40058340c85bc93cb3d
with:
coverageFile: reports/coverage.xml
token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -158,16 +162,16 @@ jobs:
- name: run sonar scan
if: success() || failure()
run: |
PATH="$PWD/sonar-scanner/bin:$PATH"
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
git checkout "${GITHUB_HEAD_REF}"
sonar-scanner -Dsonar.pullrequest.branch="{{ github.event.pull_request.head.sha }}" -Dsonar.pullrequest.base="{{ github.event.pull_request.base.sha }}" -Dsonar.pullrequest.key="${{ github.event.number }}"
else
sonar-scanner
fi
PATH="$PWD/sonar-scanner/bin:$PATH"
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
git checkout "${GITHUB_HEAD_REF}"
sonar-scanner -Dsonar.pullrequest.branch="{{ github.event.pull_request.head.sha }}" -Dsonar.pullrequest.base="{{ github.event.pull_request.base.sha }}" -Dsonar.pullrequest.key="${{ github.event.number }}"
else
sonar-scanner
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

- name: archive reports
if: success() || failure()
Expand All @@ -192,7 +196,7 @@ jobs:
if: github.repository == 'NHSDigital/nhs-aws-helpers'
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand All @@ -206,11 +210,14 @@ jobs:
- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
git checkout "${{ github.base_ref }}"
echo base branch "$BASE_BRANCH"
echo pr branch "$PR_BRANCH"
git checkout "$BASE_BRANCH"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
env:
BASE_BRANCH: ${{ github.base_ref }}
PR_BRANCH: ${{ github.head_ref }}

- name: setup python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -262,7 +269,6 @@ jobs:
echo "RELEASE_VERSION=$version" >> $GITHUB_ENV
echo "${version}"


publish:
runs-on: ubuntu-latest
if: github.repository == 'NHSDigital/nhs-aws-helpers' && github.actor != 'dependabot[bot]'
Expand All @@ -272,7 +278,7 @@ jobs:
- tox
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scheduled-combine-dependabot-prs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
steps:
- name: combine-prs
id: combine-prs
uses: github/combine-prs@v5.0.0
uses: github/combine-prs@v5.2.0
with:
ci_required: ${{ inputs.ci_required == 'YES' }}
labels: dependencies
Expand Down
Loading
Loading