CCM-12352: Internal package refactor #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-houston
force-pushed
the
feature/CCM-12352-refactor-helpers-and-datastore
branch
from
f918d4a to
4bca3e4
Compare
…tore # Conflicts: # scripts/config/vale/styles/config/vocabularies/words/accept.txt
…s-and-datastore # Conflicts: # lambdas/api-handler/src/infrastructure/letter-repo-factory.ts # lambdas/api-handler/src/services/__tests__/letter-operations.test.ts
…tore # Conflicts: # lambdas/api-handler/src/mappers/__tests__/letter-mapper.test.ts # lambdas/api-handler/src/mappers/letter-mapper.ts
m-houston
commented
Oct 27, 2025
masl2
previously approved these changes
Oct 29, 2025
stevebux
reviewed
Oct 29, 2025
stevebux
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the datastore package to separate out helpers which will be used in event schema package, which will be added in #197
Context
Adds an
internal/helperspackage to support consistent, type-safe domain modelling and validation.Several composable Zod schemas are factored out:
Utility functions for identified objects with nominal typing for IDs
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.