Skip to content

Conversation

@nhsd-david-wass
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass nhsd-david-wass requested a review from a team as a code owner November 11, 2025 14:26
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12590-Failure-Codes branch from d1d8750 to 740bc69 Compare November 11, 2025 14:26
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12590-Failure-Codes branch from 4b76649 to 0a083aa Compare November 13, 2025 10:23
Copy link
Contributor

@francisco-videira-nhs francisco-videira-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

Copy link
Contributor

@masl2 masl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec was already update, so LGTM

@nhsd-david-wass nhsd-david-wass merged commit 38c1fa6 into main Nov 17, 2025
41 checks passed
@nhsd-david-wass nhsd-david-wass deleted the feature/CCM-12590-Failure-Codes branch November 17, 2025 09:40
masl2 pushed a commit that referenced this pull request Jan 5, 2026
* CCM-12590 - Update failure reason code to string

* Update sandbox and OAS descriptions

Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants