Feature/ccm 12937- publish supplier letter events #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebux
force-pushed
the
feature/CCM-12937
branch
4 times, most recently
from
32e0f95 to
df10891
Compare
stevebux
force-pushed
the
feature/CCM-12937
branch
from
8e03bf0 to
0fdb97b
Compare
Contributor
Author
|
I've inserted an extra lambda (letter-stream-forwarder) in between the DynamoDB stream and the Kinesis stream - this seems to be the accepted way to connect DynamoDB to a Kinesis stream. The alternative would be to connect the DynamoDB stream directly to the letter-updates-transformer lambda, cut out Kinesis altogether |
m-houston
reviewed
Dec 2, 2025
infrastructure/terraform/components/api/event_source_mapping_letter_updates.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/api/event_source_mapping_letter_updates.tf
Outdated
Show resolved
Hide resolved
internal/events/src/events/__tests__/testData/letter.ACCEPTED-with-invalid-major-version.json
Outdated
Show resolved
Hide resolved
lambdas/letter-updates-transformer/src/mappers/letter-mapper.ts
Outdated
Show resolved
Hide resolved
stevebux
force-pushed
the
feature/CCM-12937
branch
2 times, most recently
from
9427ebe to
7a88838
Compare
m-houston
reviewed
Dec 3, 2025
stevebux
force-pushed
the
feature/CCM-12937
branch
from
7a88838 to
b055f5e
Compare
sidnhs
previously approved these changes
Dec 3, 2025
m-houston
requested changes
Dec 3, 2025
Contributor
m-houston
left a comment
m-houston
left a comment
There was a problem hiding this comment.
Pending the supplierId field, all LGTM
lambdas/letter-updates-transformer/src/mappers/letter-mapper.ts
Outdated
Show resolved
Hide resolved
stevebux
force-pushed
the
feature/CCM-12937
branch
from
8a0b1fd to
dcd242b
Compare
m-houston
reviewed
Dec 4, 2025
m-houston
previously approved these changes
Dec 4, 2025
m-houston
reviewed
Dec 5, 2025
nhsd-david-wass
previously approved these changes
Dec 10, 2025
masl2
reviewed
Dec 10, 2025
m-houston
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.