Skip to content

CCM-12673 - Make PR proxies temporary #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nhsd-david-wass merged 4 commits into from
Dec 11, 2025
Merged

CCM-12673 - Make PR proxies temporary #286

nhsd-david-wass merged 4 commits into from
Dec 11, 2025

Conversation

@nhsd-david-wass
Copy link
Contributor

@nhsd-david-wass nhsd-david-wass commented Dec 5, 2025

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass nhsd-david-wass requested a review from a team as a code owner December 5, 2025 10:55
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12673 branch 3 times, most recently from bc10a43 to 6b9498d Compare December 8, 2025 09:14
masl2
masl2 reviewed Dec 10, 2025
View reviewed changes
@nhsd-david-wass nhsd-david-wass merged commit d3e95f2 into main Dec 11, 2025
34 checks passed
@nhsd-david-wass nhsd-david-wass deleted the feature/CCM-12673 branch December 11, 2025 07:42
masl2 pushed a commit that referenced this pull request Jan 5, 2026
@nhsd-david-wass @masl2
CCM-12673 - Make PR proxies temporary (#286)
0edec05 
* CCM-12673 - Make PR proxies temporary

* Another refactor and include security

* Update monitoring to true for all envs except PRs

* sandbox authorization optional

Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masl2 masl2 masl2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nhsd-david-wass @masl2