Skip to content

Make letter amendments queue FIFO #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevebux wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make letter amendments queue FIFO #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62edfe0
Make letter amendments queue FIFO
stevebux Dec 18, 2025
b8be126
Make SNS topic FIFO too
stevebux Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions infrastructure/terraform/components/api/module_sqs_letter_updates.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ module "sqs_letter_updates" {
source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip"

aws_account_id = var.aws_account_id
component = var.component
environment = var.environment
project = var.project
region = var.region
name = "letter-updates"
component = var.component
environment = var.environment
project = var.project
region = var.region
name = "letter-updates"
fifo_queue = true
content_based_deduplication = true


sqs_kms_key_arn = module.kms.key_arn

Expand Down
6 changes: 4 additions & 2 deletions infrastructure/terraform/modules/eventsub/sns_topic.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
resource "aws_sns_topic" "main" {
name = local.csi
kms_master_key_id = var.kms_key_arn
name = local.csi
kms_master_key_id = var.kms_key_arn
fifo_topic = true
content_based_deduplication = true

application_failure_feedback_role_arn = var.enable_sns_delivery_logging == true ? aws_iam_role.sns_delivery_logging_role[0].arn : null
application_success_feedback_role_arn = var.enable_sns_delivery_logging == true ? aws_iam_role.sns_delivery_logging_role[0].arn : null
Expand Down
Loading