generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/ccm 12180 test on pipeline re sign #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Add event schemas for supplier-api domain * Update event naming and metadata based on review * Unify envelope with letter-rendering domain events using origin subject prefix * Add group and specification IDs to letter event domain model * Add group and specification IDs to letter event example * Fix missing domain in origin examples * Updates to envelope URIs and source/subject paths * Add more examples for different statuses * Fix linting config * Fix linting config * Add source field back to origin as this scopes the subject * Update package-lock conflicts * Regenerate schemas * Add empty test:unit script for tests package * CCM-12352: Remove unneeded README.md from events package Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Bump actions/download-artifact from 5 to 6 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump nhsuk-frontend from 8.3.0 to 10.1.0 Bumps [nhsuk-frontend](https://github.com/nhsuk/nhsuk-frontend) from 8.3.0 to 10.1.0. - [Release notes](https://github.com/nhsuk/nhsuk-frontend/releases) - [Changelog](https://github.com/nhsuk/nhsuk-frontend/blob/main/CHANGELOG.md) - [Commits](nhsuk/nhsuk-frontend@v8.3.0...v10.1.0) --- updated-dependencies: - dependency-name: nhsuk-frontend dependency-version: 10.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump typescript from 5.9.2 to 5.9.3 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.2 to 5.9.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml) - [Commits](microsoft/TypeScript@v5.9.2...v5.9.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 5.9.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @openapitools/openapi-generator-cli from 2.23.4 to 2.25.0 Bumps [@openapitools/openapi-generator-cli](https://github.com/OpenAPITools/openapi-generator-cli) from 2.23.4 to 2.25.0. - [Release notes](https://github.com/OpenAPITools/openapi-generator-cli/releases) - [Changelog](https://github.com/OpenAPITools/openapi-generator-cli/blob/master/.releaserc) - [Commits](OpenAPITools/openapi-generator-cli@v2.23.4...v2.25.0) --- updated-dependencies: - dependency-name: "@openapitools/openapi-generator-cli" dependency-version: 2.25.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @redocly/cli from 1.34.5 to 2.8.0 Bumps [@redocly/cli](https://github.com/Redocly/redocly-cli) from 1.34.5 to 2.8.0. - [Release notes](https://github.com/Redocly/redocly-cli/releases) - [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@1.34.5...@redocly/cli@2.8.0) --- updated-dependencies: - dependency-name: "@redocly/cli" dependency-version: 2.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github/codeql-action from 4.31.0 to 4.31.2 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.0 to 4.31.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update .gitleaksignore added gitleaks ignore * Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/yargs-18.0.0' into dependabotCombined * update lock * Bump nhsuk-frontend from 8.3.0 to 10.1.0 Bumps [nhsuk-frontend](https://github.com/nhsuk/nhsuk-frontend) from 8.3.0 to 10.1.0. - [Release notes](https://github.com/nhsuk/nhsuk-frontend/releases) - [Changelog](https://github.com/nhsuk/nhsuk-frontend/blob/main/CHANGELOG.md) - [Commits](nhsuk/nhsuk-frontend@v8.3.0...v10.1.0) --- updated-dependencies: - dependency-name: nhsuk-frontend dependency-version: 10.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @openapitools/openapi-generator-cli from 2.23.4 to 2.25.0 Bumps [@openapitools/openapi-generator-cli](https://github.com/OpenAPITools/openapi-generator-cli) from 2.23.4 to 2.25.0. - [Release notes](https://github.com/OpenAPITools/openapi-generator-cli/releases) - [Changelog](https://github.com/OpenAPITools/openapi-generator-cli/blob/master/.releaserc) - [Commits](OpenAPITools/openapi-generator-cli@v2.23.4...v2.25.0) --- updated-dependencies: - dependency-name: "@openapitools/openapi-generator-cli" dependency-version: 2.25.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump yargs from 17.7.2 to 18.0.0 Bumps [yargs](https://github.com/yargs/yargs) from 17.7.2 to 18.0.0. - [Release notes](https://github.com/yargs/yargs/releases) - [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md) - [Commits](yargs/yargs@v17.7.2...v18.0.0) --- updated-dependencies: - dependency-name: yargs dependency-version: 18.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump typescript from 5.9.2 to 5.9.3 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.2 to 5.9.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml) - [Commits](microsoft/TypeScript@v5.9.2...v5.9.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 5.9.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @redocly/cli from 1.34.5 to 2.8.0 Bumps [@redocly/cli](https://github.com/Redocly/redocly-cli) from 1.34.5 to 2.8.0. - [Release notes](https://github.com/Redocly/redocly-cli/releases) - [Commits](https://github.com/Redocly/redocly-cli/compare/@redocly/cli@1.34.5...@redocly/cli@2.8.0) --- updated-dependencies: - dependency-name: "@redocly/cli" dependency-version: 2.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update package-lock.json * Downgrade openapi gen and redocly --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tim Ireland <tim.ireland@hscic.gov.uk> Co-authored-by: Mark Slowey <mark.slowey1@nhs.net> Co-authored-by: Mike Houston <michael.houston4@nhs.net> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Update event schema envelope generation * Add MI Submitted event schema and update async API spec * Add CI workflow for event schemas version check and publishing * Fix main branch events package version detection * Increment patch version of events - new MI event added, but no breaking changes to Letter * Update CI workflows to enhance node_modules caching and versioning * Add nodejs_version input to build proxies action and implement caching for node_modules * Temporarily call a fixed branch for build_proxies workflow in internal. * Update events package configuration for NPM publication * Remove generated files and check for up-to-date generation * Update .gitignore for generated files * Add MI schema validation tests and example event JSON files * Remove notify-internal branch override for proxy deployment * Remove unused workflow actions for tests --------- Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Add post letters endpoint * Fix names * Fix event mapper * Fix sqs * Fix arn * Fix sqs name * Fix param * Fix attempt * Fix attempt sqs * Fix attempt await * Clean up tests * Naming and minor refactor * Add duplicate validation * Change handler name * Fix unit tests Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* suppress readme secrets false positive * add supplier-api-admins to infra approvers Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* add product id header * CCM-11600: supplier repository and table * CCM-11600: cli interface for supplier repo * CCM-11600: lock for new packages * Update .gitleaksignore added gitleaks ignore * CCM-11600: fix some imports * Add certificate expiry check * Added supplier ID lookup * Test fix * Further development * Fix dependencies * Temp commit to force cloudwatch logging * Removed Cloudwatch client * Tidy up packages * CCM-11600: correct target attr * CCM-11600: header name, targets, add alarm * CCM-11600: correct env ref * CCM-11600: fix header lookup * lockfile * remove placeholder blurb * fix copy pasta * workspace refs * lock * CCM-11600: header references, format, name consistency --------- Co-authored-by: David Wass <david.wass2@nhs.net> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Co-authored-by: Mark Slowey <mark.slowey1@nhs.net> Co-authored-by: Tim Ireland <tim.ireland@hscic.gov.uk> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Add post letters endpoint * Fix names * Fix event mapper * Fix sqs * Fix arn * Fix sqs name * Fix param * Fix attempt * Fix attempt sqs * Fix attempt await * Clean up tests * Naming and minor refactor * Add duplicate validation * Change handler name * Fix unit tests * Change patch to return 202 and use sqs * Add await * Change mapper name Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* CCM-12649 Get status healthcheck endpoint * Address review comments * Fix following merge with main * Avoid leaking system details in 500 error message * Tidy up @internal paths * Update .gitleaksignore added gitleaks ignore * Fix logging in error mapper * Address review comments * Terraform fix * Allow for no headers * Change response shape --------- Co-authored-by: Tim Ireland <tim.ireland@hscic.gov.uk> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Co-authored-by: Francisco Videira <francisco.videira@nhs.net> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* CCM-12995 Adding base eventPub Infra * CCM-12995: Adding sns topic policy for sub * CCM-12995: Adding sns topic policy for sub * CCM-12995: Adding sns topic policy for sub * CCM-12995 Adding base eventPub Infra * CCM-12995 Adding base eventPub Infra * CCM-12312: Fixing typo in kms policy * CCM-12995: Fix comment * CCM-12995: Update package-lock.json * CCM-12995: Update package-lock.json * CCM-12995: Revert python version back to 3.12 --------- Co-authored-by: sidnhs <siddharth.nair1@nhs.net> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* Fix reference to test-contract make target * Restore README.md Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* CCM-13038: initial * CCM-13038: implement parsing on PACT consumer test * suppress leak warning for test data * CCM-13038: generate correct consumer pacts * CCM-13038: set GITHUB token when reading packages * CCM-13038: use node action * CCM-13038: use node action * CCM-13038: test publish contracts on package contract change * CCM-13038: set _authToken on gpr repo on CI * CCM-13038: pass GITHUB token to action * CCM-13038: ignore EOF lines for contracts * CCM-13038: use branch version of internal repo * CCM-13038: use script in pre.sh * CCM-13038: revert back to main * CCM-13038: redeploy * CCM-13038: update source * CCM-13038: loosen restrictions on dataschema minor and patch * CCM-13038: remove setup-github-token.sh from install action and use passed in node_version * CCM-13038: use NODE_AUTH_TOKEN for pact-test job --------- Co-authored-by: Mark Slowey <mark.slowey1@nhs.net> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* add suppression * update version in pact Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
* CCM-13419 Refactor build steps * CCM-13419 Generate specification variants on build * Add permissions * Post review comment * Only build OAS variants if push is to main --------- Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.