Feature/ccm 12951 Switch letter_status_update lambda to use eventsub SNS topic #360
Conversation
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
2 times, most recently
from
b2a5207 to
94171d9
Compare
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
from
94171d9 to
966f6eb
Compare
| return { | ||
| s3Client: new S3Client(), | ||
| sqsClient: new SQSClient(), | ||
| snsClient: new SNSClient(), |
There was a problem hiding this comment.
for these clients we don't specify the region.
Are we sure they are assigned the correct region?
There was a problem hiding this comment.
As I understand it, when you create an AWS client inside a lambda, it inherits the region from where the lambda is executed. (Which will be eu-west-2 as that's what's configured in the terraform in the nhs-notify-internal project). I suppose that might be an issue for services that are only available in a limited number of regions, but that doesn't seem to be a problem here.
stevebux
dismissed stale reviews from sidnhs and Vlasis-Perdikidis
via
e5b9274
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
from
5bf0071 to
d11f96f
Compare
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
from
94f88f0 to
630d113
Compare
stevebux
changed the title
| # Moved blocks to handle resource renames without destroy/recreate | ||
|
|
||
| moved { | ||
| from = module.letter_status_updates_queue | ||
| to = module.amendments_queue | ||
| } | ||
|
|
||
| moved { | ||
| from = module.letter_status_update | ||
| to = module.amendment_event_transformer | ||
| } |
There was a problem hiding this comment.
For the lambda a destory and recreate is fine (and would likely happen anyway given the package changes)
For the queue I'd suggest we add the new one with the updated subscriptions without deleting the original
then in a subsequent release we can remove it once we're sure it's empty
5 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.