Refactor OAS file and make rules for OAS file #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhsd-david-wass
force-pushed
the
CCM-11101-Maintain-OAS-File
branch
3 times, most recently
from
1568793 to
229fe75
Compare
m-houston
previously approved these changes
Jul 25, 2025
Contributor
There was a problem hiding this comment.
This is great - sorry for the pedantic review comments.
I know you said this wasn't a final version, and most of the response schema changes can wait until later. This will be a great place to start from.
Don't feel the need to rename or move things around because of these comments, close any that you think will be addressed in later passes 👍
nhsd-david-wass
force-pushed
the
CCM-11101-Maintain-OAS-File
branch
15 times, most recently
from
e2c26fb to
a506daa
Compare
m-houston
previously approved these changes
Aug 1, 2025
francisco-videira-nhs
requested changes
Aug 1, 2025
Contributor
francisco-videira-nhs
left a comment
francisco-videira-nhs
left a comment
There was a problem hiding this comment.
Looks good to me. Just missing the paths changing to 'letters' (had a chat about it in the office).
nhsd-david-wass
force-pushed
the
CCM-11101-Maintain-OAS-File
branch
from
a506daa to
9ec1c09
Compare
nhsd-david-wass
force-pushed
the
CCM-11101-Maintain-OAS-File
branch
from
9ec1c09 to
73d6b2e
Compare
nhsd-david-wass
force-pushed
the
CCM-11101-Maintain-OAS-File
branch
from
73d6b2e to
10dc52c
Compare
francisco-videira-nhs
approved these changes
Aug 1, 2025
m-houston
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.