Skip to content

Conversation

@aidenvaines-cgi
Copy link
Contributor

@aidenvaines-cgi aidenvaines-cgi commented Aug 29, 2025

Description

  • Moves all workflow steps which trigger a remote workflow into a single endpoint script. which properly waits for completion/failure of said workflow
  • Removes the 'dispatch' workflow which is the second way this was been done
  • Moves the Sandbox destruction job to the same workflow as the PR environment
  • Moves the sandbox and dynamic pr environment to sharing an environment name for easier identifycation - sorry Mark not the generated name using the CCM ticket, im scared about character limits etc
  • updated the reusable job to use said script
  • updated the acceptance test to have a sequential update the sandbox before running the tests - previously it was parallel but using a 'needs' statement for some strange reason
  • Drops the need for callerRunId/JobName as the search now properly identifies the job

Context

We found that multiple branches in this and some other repos which copy workflow ideas had started running in to challenges with build lockstep, race conditions and general instability.

The root cause seems to have been triggering remote workflows in several different ways.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-cgi aidenvaines-cgi requested a review from a team as a code owner August 29, 2025 10:55
@aidenvaines-cgi aidenvaines-cgi requested a review from a team as a code owner September 1, 2025 08:25
mark-r-bjss
mark-r-bjss previously approved these changes Sep 1, 2025
@aidenvaines-cgi aidenvaines-cgi merged commit b0e3162 into main Sep 1, 2025
30 checks passed
@aidenvaines-cgi aidenvaines-cgi deleted the CCM-11942_WorkflowFixesForPRWaiting branch September 1, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants