generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
CCM-12666: playwright accessibility tests #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnuttall
reviewed
Oct 31, 2025
…emplate-management into feature/CCM-12666_playwright-accessibility
…emplate-management into feature/CCM-12666_playwright-accessibility
bhansell1
commented
Nov 11, 2025
…emplate-management into feature/CCM-12666_playwright-accessibility
…github.com/NHSDigital/nhs-notify-web-template-management into feature/CCM-12666_playwright-accessibility
bhansell1
commented
Nov 11, 2025
alexnuttall
approved these changes
Nov 12, 2025
tests/test-team/template-mgmt-accessibility/routing.accessibility.spec.ts
Show resolved
Hide resolved
ClareJonesBJSS
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds accessibility tests fro the routing pages to Playwright. Following the suggested approach outlined here.
The
AxeBuilder.withTags is an inclusive list which is why we go forWCAG2A,WCAG2AAandWCAGAAA.One major change from pa11y-ci is that we're now tetsing against the full suite of WCAG2AAA rules expect for colour contrast. The reason for this is because I wanted to replicate the AAA rules from PRINCIPLE_1_3_1_AAA. If we find the rule too restrictive then we can remove it.
Context
We've been encountering issues with Pa11y-ci and tests timingout due to resource limit.
This can be seen both locally and in CI. We've attempted alternative solutions to mitigate the issue, but they're going to push the issue further down the line when we eventually add more routes to test.
We've decieded that the best approach would be to leave the current accessibility tests as they are and use Playwright for the new routing pages. With the plan to migrate the existing pa11y-ci tests over.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.