generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
CCM-12744: routing config optimistic locking #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
harrim91
merged 14 commits into
main
from
feature/CCM-12744-routing-config-optimistic-locking
Dec 1, 2025
Merged
CCM-12744: routing config optimistic locking #770
harrim91
merged 14 commits into
main
from
feature/CCM-12744-routing-config-optimistic-locking
Dec 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/entity-update-command-builder/src/routing-config-update-builder.ts
Show resolved
Hide resolved
alexnuttall
previously approved these changes
Nov 25, 2025
alexnuttall
approved these changes
Nov 27, 2025
avaines
previously approved these changes
Nov 27, 2025
aidenvaines-cgi
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search param is now required on
Also had to make a lot of changes to the playwright tests to support both multiple path parameters and search parameters.
The result is (I think) a simpler pages model - have got rid of the DynamicBasePage/NonDynamicBasePage subclasses
But this PR is now huge because I had to update ALL of the tests.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.