[CCM-11494] Alternative letter formats #772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate-management into feature/CCM-11494-choose-letter-formats
bhansell1
reviewed
Nov 27, 2025
frontend/src/__tests__/app/choose-templates/__snapshots__/page.test.tsx.snap
Show resolved
Hide resolved
bhansell1
reviewed
Nov 27, 2025
...src/components/molecules/MessagePlanConditionalTemplates/MessagePlanConditionalTemplates.tsx
Show resolved
Hide resolved
bhansell1
reviewed
Nov 27, 2025
...end/src/components/molecules/MessagePlanFallbackConditions/MessagePlanFallbackConditions.tsx
Show resolved
Hide resolved
bhansell1
previously approved these changes
Nov 27, 2025
bhansell1
approved these changes
Nov 27, 2025
harrim91
reviewed
Dec 1, 2025
Contributor
harrim91
left a comment
harrim91
left a comment
There was a problem hiding this comment.
Just a couple of tiny things
| return null; | ||
| } | ||
|
|
||
| const accessibleFormats = ACCESSIBLE_FORMATS; |
Contributor
There was a problem hiding this comment.
Really unimportant but why is this assignment needed?
| /** | ||
| * Collects all remaining language types from the cascade | ||
| */ | ||
| export function getRemainingLanguages(cascade: CascadeItem[]): Language[] { |
Contributor
There was a problem hiding this comment.
nit: can these be called getCascadeLanguages rather than getRemaining... - I wasn't sure what "remaining" was referring to until I saw how the context in which the function was being called.
mark-r-bjss
reviewed
Dec 15, 2025
| ); | ||
| } | ||
|
|
||
| export function MessagePlanLanguageTemplate({ |
Contributor
There was a problem hiding this comment.
(Opinionated): Putting these into separate files would improve readability and would discourage growing the file excessively in the future.
mark-r-bjss
reviewed
Dec 15, 2025
| /** | ||
| * Collects all remaining accessible format types from the cascade | ||
| */ | ||
| export function getRemainingAccessibleFormats( |
Contributor
There was a problem hiding this comment.
(Opinionated): You can avoid the continue and nested ifs with something like:
export function getRemainingAccessibleFormatsAlt(cascade: CascadeItem[]): LetterType[] {
const formats = cascade
.filter((item) => item.conditionalTemplates)
.flatMap((item) => item.conditionalTemplates)
.filter((template) => 'accessibleFormat' in template && template.templateId)
.map((template) => template.accessibleFormat)
.reduce((acc, format) => acc.add(format), new Set<LetterType>());
return [...formats];
}
mark-r-bjss
approved these changes
Dec 15, 2025
Contributor
Author
|
superseded by #778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessagePlanChannelTemplatecomponent for accessible formats and foreign language templatesScreenshots
Without templates selected:
With templates selected:
Context
As an integrator I Want to link accessible format (Large print and Other languages) to a message plan
And review it So that I can verify if the message plan is correct
Choosing accessible format letter will be possible but it is optional. The user will be able to select the template they need and also remove it or change it.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.