Skip to content

CCM-11473: display locked status on submitted templates #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harrim91 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CCM-11473: display locked status on submitted templates #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04dd359
CCM-11473: display locked status on submitted templates
harrim91 Dec 19, 2025
16e75fb
CCM-11473: warning callout
harrim91 Dec 22, 2025
7a9f9d3
Merge branch 'main' into feature/CCM-11473_locked-template-status
harrim91 Dec 22, 2025
91be3f9
CCM-11473: update playwright tests
harrim91 Dec 22, 2025
daace1e
CCM-11473: testid consistency
harrim91 Dec 22, 2025
2e30b65
CCM--11473: fix test href attribute
harrim91 Dec 23, 2025
7404b4a
Merge branch 'main' into feature/CCM-11473_locked-template-status
harrim91 Dec 23, 2025
bc461f0
CCM-11473: only show lock warning callout for locked templates
harrim91 Dec 23, 2025
71fe5e8
Merge branch 'main' into feature/CCM-11473_locked-template-status
harrim91 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ...__/components/forms/PreviewEmailTemplate/__snapshots__/PreviewEmailTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ exports[`Preview email form renders Routing feature flag - Disabled Client-side
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -384,7 +385,8 @@ exports[`Preview email form renders Routing feature flag - Disabled matches erro
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -642,7 +644,8 @@ exports[`Preview email form renders matches snapshot when navigating from edit s
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -888,7 +891,8 @@ exports[`Preview email form renders matches snapshot when navigating from edit s
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -1053,7 +1057,8 @@ exports[`Preview email form renders matches snapshot when navigating from manage
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -1294,7 +1299,8 @@ exports[`Preview email form renders matches snapshot when navigating from manage
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down
18 changes: 12 additions & 6 deletions .../components/forms/PreviewNHSAppTemplate/__snapshots__/PreviewNHSAppTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ exports[`Preview nhs app form renders Routing feature flag - Disabled Client-sid
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -360,7 +361,8 @@ exports[`Preview nhs app form renders Routing feature flag - Disabled matches er
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -594,7 +596,8 @@ exports[`Preview nhs app form renders matches snapshot when navigating from edit
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -816,7 +819,8 @@ exports[`Preview nhs app form renders matches snapshot when navigating from edit
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -957,7 +961,8 @@ exports[`Preview nhs app form renders matches snapshot when navigating from mana
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -1174,7 +1179,8 @@ exports[`Preview nhs app form renders matches snapshot when navigating from mana
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down
18 changes: 12 additions & 6 deletions ...ests__/components/forms/PreviewSMSTemplate/__snapshots__/PreviewSMSTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ exports[`Review sms form renders Routing feature flag - Disabled Client-side val
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -359,7 +360,8 @@ exports[`Review sms form renders Routing feature flag - Disabled matches error s
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -592,7 +594,8 @@ exports[`Review sms form renders matches snapshot when navigating from edit scre
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -813,7 +816,8 @@ exports[`Review sms form renders matches snapshot when navigating from edit scre
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -953,7 +957,8 @@ exports[`Review sms form renders matches snapshot when navigating from manage te
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down Expand Up @@ -1169,7 +1174,8 @@ exports[`Review sms form renders matches snapshot when navigating from manage te
>
<strong
class="nhsuk-tag nhsuk-tag--green"
data-test-id="status-tag-not-yet-submitted"
data-status="not-yet-submitted"
data-testid="status-tag"
>
Draft
</strong>
Expand Down
13 changes: 11 additions & 2 deletions frontend/src/__tests__/components/molecules/MessageTemplates.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ import { render, screen } from '@testing-library/react';
import { MessageTemplates } from '@molecules/MessageTemplates/MessageTemplates';
import content from '@content/content';
import { TemplateDto } from 'nhs-notify-backend-client';
import { useFeatureFlags } from '@providers/client-config-provider';

jest.mock('@providers/client-config-provider');

beforeEach(() => {
jest.resetAllMocks();
jest.mocked(useFeatureFlags).mockReturnValue({ routing: false });
});

const messageTemplatesContent = content.pages.messageTemplates;

Expand Down Expand Up @@ -75,8 +83,9 @@ describe('MessageTemplates component', () => {
expect(container.asFragment()).toMatchSnapshot();
});

it('matches snapshot with submitted status', () => {
messageTemplatesProps.templateList[0].templateStatus = 'SUBMITTED';
it('matches snapshot with routing flag enabled', () => {
jest.mocked(useFeatureFlags).mockReturnValue({ routing: true });

const container = render(<MessageTemplates {...messageTemplatesProps} />);

expect(container.asFragment()).toMatchSnapshot();
Expand Down
Loading