Skip to content

CCM-11575: reposition error summary on copy page #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harrim91 merged 2 commits into from
Dec 23, 2025
Merged

CCM-11575: reposition error summary on copy page #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c797f6a
CCM-11575: reposition error summary on copy page
harrim91 Dec 23, 2025
bfb83b3
Merge branch 'main' into bugfix/CCM-11757_copy-page-error-sumary
harrim91 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions ...tend/src/__tests__/components/forms/CopyTemplate/__snapshots__/CopyTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,31 @@ exports[`Choose template page Client-side validation triggers 1`] = `
id="maincontent"
role="main"
>
<div
aria-labelledby="error-summary-title"
class="nhsuk-error-summary"
role="alert"
tabindex="-1"
>
<h2
class="nhsuk-error-summary__title"
data-testid="error-summary"
id="error-summary-title"
>
There is a problem
</h2>
<ul
class="nhsuk-list nhsuk-error-summary__list"
>
<li>
<a
href="#templateType"
>
Select a template type
</a>
</li>
</ul>
</div>
<div
class="nhsuk-grid-row"
>
Expand All @@ -25,31 +50,6 @@ exports[`Choose template page Client-side validation triggers 1`] = `
>
Copy 'undefined'
</h1>
<div
aria-labelledby="error-summary-title"
class="nhsuk-error-summary"
role="alert"
tabindex="-1"
>
<h2
class="nhsuk-error-summary__title"
data-testid="error-summary"
id="error-summary-title"
>
There is a problem
</h2>
<ul
class="nhsuk-list nhsuk-error-summary__list"
>
<li>
<a
href="#templateType"
>
Select a template type
</a>
</li>
</ul>
</div>
<form
action="/action"
>
Expand Down Expand Up @@ -193,6 +193,31 @@ exports[`Choose template page renders error component 1`] = `
id="maincontent"
role="main"
>
<div
aria-labelledby="error-summary-title"
class="nhsuk-error-summary"
role="alert"
tabindex="-1"
>
<h2
class="nhsuk-error-summary__title"
data-testid="error-summary"
id="error-summary-title"
>
There is a problem
</h2>
<ul
class="nhsuk-list nhsuk-error-summary__list"
>
<li>
<a
href="#page"
>
Component error message
</a>
</li>
</ul>
</div>
<div
class="nhsuk-grid-row"
>
Expand All @@ -204,31 +229,6 @@ exports[`Choose template page renders error component 1`] = `
>
Copy 'undefined'
</h1>
<div
aria-labelledby="error-summary-title"
class="nhsuk-error-summary"
role="alert"
tabindex="-1"
>
<h2
class="nhsuk-error-summary__title"
data-testid="error-summary"
id="error-summary-title"
>
There is a problem
</h2>
<ul
class="nhsuk-list nhsuk-error-summary__list"
>
<li>
<a
href="#page"
>
Component error message
</a>
</li>
</ul>
</div>
<form
action="/action"
>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/forms/CopyTemplate/CopyTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ export const CopyTemplate = ({ template }: CopyTemplate) => {
<NotifyBackLink>{backLinkText}</NotifyBackLink>
</Link>
<NHSNotifyMain>
<NhsNotifyErrorSummary errorState={errorState} />
<div className='nhsuk-grid-row'>
<div className='nhsuk-grid-column-two-thirds'>
<h1 className='nhsuk-heading-xl'>{fullPageHeading}</h1>
<NhsNotifyErrorSummary errorState={errorState} />
<NHSNotifyRadioButtonForm
formId='choose-a-template-type'
radiosId='templateType'
Expand Down
Loading