generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
CCM-14062: routing e2e #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexnuttall
wants to merge
32
commits into
feature/CCM-11970_submit-plan-page
Choose a base branch
from
feature/CCM-14062-routing-e2e
base: feature/CCM-11970_submit-plan-page
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CCM-14062: routing e2e #827
alexnuttall
wants to merge
32
commits into
feature/CCM-11970_submit-plan-page
from
feature/CCM-14062-routing-e2e
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/CCM-11970_submit-plan-page
…ge' into feature/CCM-14062-routing-e2e
ClareJonesBJSS
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an e2e test for routing. Templates are seeded. AUTHORING letters are used.
Also adds template completion event assertons to routing-config.event.spec.ts. Using AUTHORING letters here means that letter completion events are currently missing (they are ignored by the publisher because they don't have the proofingEnabled flag).
Ported over the SQS/SNS-based EventSubscriber test util from core and replaced the existing s3 based util with it. Event cache buffering has been restored to the default since we don't need fast delivery for tests any more
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.