Skip to content

Conversation

@alexnuttall
Copy link
Contributor

@alexnuttall alexnuttall commented Feb 9, 2026

Description

Adds an e2e test for routing. Templates are seeded. AUTHORING letters are used.

Also adds template completion event assertons to routing-config.event.spec.ts. Using AUTHORING letters here means that letter completion events are currently missing (they are ignored by the publisher because they don't have the proofingEnabled flag).

Ported over the SQS/SNS-based EventSubscriber test util from core and replaced the existing s3 based util with it. Event cache buffering has been restored to the default since we don't need fast delivery for tests any more

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@alexnuttall alexnuttall requested review from a team as code owners February 9, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants