Record vaccination dose #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record vaccination dose for: 1. 6-in-1 2. Flu 3. MenB 4. MMRV 5. Pneumococcal Adjustments made to eligibility to cover 6-in-1, and routing amends to ensure dose page triggered dependent upon vaccination chosen.
frankieroberto
temporarily deployed
to
record-a-vac-6in1-flu-m-bcf0vg
Comment on lines
+83
to
+84
| "In an at-risk group", | ||
| "Age-based eligibility 0 to 5 years" |
Collaborator
There was a problem hiding this comment.
Should we used "Based on age" rather than "Age-based eligibility 0 to 5 years", for consistency with the others?
Could also go in alphabetical order?
Suggested change
| "In an at-risk group", | |
| "Age-based eligibility 0 to 5 years" | |
| "Based on age", | |
| "In an at-risk group" |
I also wasn't aware that this was additionally given to at-risk groups!
| } if (errors | length) > 0, | ||
| fieldset: { | ||
| legend: { | ||
| text: "Which dose of " + data.vaccine + " are you giving?", |
Collaborator
There was a problem hiding this comment.
Should we include the word "vaccine" in the question? 🤔
"Which dose of MMR are you giving?"
...makes sense but this reads a bit oddly:
"Which dose of flu are you giving?"
Suggested change
| text: "Which dose of " + data.vaccine + " are you giving?", | |
| text: "Which dose of the " + data.vaccine + " vaccine are you giving?", |
markbateman-nhs
deleted the
6in1-flu-menb-mmrv-pneumococcal-dose-sequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record vaccination dose for:
Adjustments made to eligibility to cover 6-in-1, and routing amends to ensure dose page triggered dependent upon vaccination chosen.