Skip to content

Conversation

@adfarth
Copy link
Collaborator

@adfarth adfarth commented Mar 25, 2025

Add Financial inputs: min_initial_capital_costs_before_incentives and max_initial_capital_costs_before_incentives
Add CHP output: initial_capital_costs
Aligns with REopt.jl PR: NREL/REopt.jl#491

@adfarth adfarth requested a review from zolanaj May 8, 2025 19:17
@adfarth adfarth marked this pull request as ready for review May 8, 2025 19:17
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @adfarth! I made one comment paired with implementing the recommended change. If tests pass I think this is good to merge!

@Bill-Becker
Copy link
Collaborator

@adfarth @zolanaj I'd like to make sure we're not going to make CHP run very slowly before we merge this, especially for the web tool (but also concerned about the recently-merged REopt.jl too).

@adfarth
Copy link
Collaborator Author

adfarth commented May 28, 2025

@adfarth @zolanaj I'd like to make sure we're not going to make CHP run very slowly before we merge this, especially for the web tool (but also concerned about the recently-merged REopt.jl too).

noting here that this is no longer a concern

@Bill-Becker
Copy link
Collaborator

@zolanaj @adfarth I had to merge this branch in with my other branch in the PR:
#644
So I think this PR will automatically close when I merge that PR next week. Based on the status of this PR, seems like it's good to go anyway. Just letting you know about that.

@Bill-Becker Bill-Becker merged commit fc14904 into develop Jun 16, 2025
2 checks passed
@Bill-Becker Bill-Becker mentioned this pull request Jun 16, 2025
@Bill-Becker Bill-Becker deleted the add-capex-constraint branch August 13, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants