v3.16.0 Federal defaults and GHP updates #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfarth
reviewed
Oct 8, 2025
| response = requests.get("http://" + julia_host + ":8081/chp_defaults/", json=inputs) | ||
| http_response = response.json() | ||
|
|
||
| # Check the endpoint logic with the expected selection |
Collaborator
There was a problem hiding this comment.
@hdunham just double checking that removing this test isn't removing an important check on CHP values? I'm guessing you deemed this to be fine to permanently remove?
adfarth
approved these changes
Oct 8, 2025
Collaborator
adfarth
left a comment
adfarth
left a comment
There was a problem hiding this comment.
Just one Q about the CHP test, but looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
no
Other information: