fix: fix-generate-lockfile #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
pablo-garay
force-pushed
the
pablo-garay/fix-generate-lockfile
branch
from
7481952 to
14ecb2c
Compare
Collaborator
Author
|
/ok to test c300eb2 |
chtruong814
reviewed
Nov 14, 2025
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| token: ${{ secrets.PAT }} |
Collaborator
There was a problem hiding this comment.
why does this need a PAT?
Collaborator
Author
There was a problem hiding this comment.
because with github_token by Github rules the auto-commit disables the GHA CI automatic checks after. This is why needed to add this line change. We want GHA CI checks to run after the uv lock file autocommit. Otherwise the users cannot merge and need to get it unstuck (reset soft + re-commit with user name) which users do not have a clue about
Collaborator
There was a problem hiding this comment.
Why does this similar workflow not need it?
https://github.com/NVIDIA-NeMo/Automodel/blob/main/.github/workflows/uv-lock-generation.yml
Here's an example of it working.
NVIDIA-NeMo/Automodel#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test run passed & behavior is as expected:
https://github.com/NVIDIA-NeMo/DFM/actions/runs/19349821013/job/55358881514