[None][fix] Fix copy start_logs in disagg slurm scripts

[qiaoxj07]

Summary by CodeRabbit

• Improvements
  • Enhanced log file handling and temporary storage management during benchmark execution
  • Improved cleanup and restoration procedures for benchmark artifacts
  • Added automatic recording of SLURM job node information for better job tracking
  • Updated log file naming patterns for improved consistency in benchmark result processing

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[qiaoxj07]

/bot skip --comment "slurm scripts are not protected in CI pipeline"

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes modify log file handling in SLURM benchmark scripts by updating file naming patterns to 3_output_CTX_ and 3_output_GEN_ prefixes, introducing temporary staging directories for start logs with cleanup mechanisms, and adding SLURM job node list recording.

Changes

Cohort / File(s)	Summary
Temporary start_logs staging mechanism examples/disaggregated/slurm/benchmark/run_benchmark.sh, examples/disaggregated/slurm/benchmark/run_benchmark_nv_sa.sh	Introduces temporary directory at /tmp/${SLURM_JOB_ID}/start_logs for staging start log files, with new cleanup logic in clean mode to restore logs from temporary storage back to log_path/start_logs and remove temporary directory.
Log file naming pattern updates examples/disaggregated/slurm/benchmark/run_benchmark_nv_sa.sh	Replaces glob patterns from output_ctx_*.log and output_gen_*.log to 3_output_CTX_*.log and 3_output_GEN_*.log, updating corresponding sed-based extraction patterns for context and generation indices.
SLURM job tracking examples/disaggregated/slurm/benchmark/submit.py	Adds command to record SLURM job node list by writing to log_dir/8_done_${SLURM_JOB_ID}.txt and appends this command to generated client_cmds.sh.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete, containing only the template structure without filling in required sections like Description, Test Coverage, or meaningful details about the issue and solution.	Add a detailed description explaining the issue being fixed, the solution implemented, relevant test coverage, and ensure all template sections are properly filled with meaningful content.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing how start_logs are copied in disaggregated SLURM scripts. It is concise, specific, and clearly relates to the core objective of the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #32735 [ skip ] triggered by Bot. Commit: 1c7c3cb

[tensorrt-cicd]

PR_Github #32735 [ skip ] completed with state SUCCESS. Commit: 1c7c3cb
Release Check Pipeline #3010 failed

[qiaoxj07]

/bot skip --comment "slurm scripts are not protected in CI pipeline"

[tensorrt-cicd]

PR_Github #32758 [ skip ] triggered by Bot. Commit: 0dd6f53

[tensorrt-cicd]

PR_Github #32758 [ skip ] completed with state SUCCESS. Commit: 0dd6f53
Skipping testing for commit 0dd6f53