Skip to content

[https://nvbugs/5688721][fix] unwaive NemotronH accuracy test#10852

Merged
lucaslie merged 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:ll/fix_5688721
Jan 22, 2026
Merged

[https://nvbugs/5688721][fix] unwaive NemotronH accuracy test#10852
lucaslie merged 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:ll/fix_5688721

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Jan 20, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped integration test to restore automated validation coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie
Copy link
Member Author

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Jan 20, 2026
@lucaslie lucaslie requested a review from EmmaQiaoCh January 20, 2026 16:49
@lucaslie
Copy link
Member Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

A single test entry was removed from the skip list in the integration test waiver configuration. The test accuracy/test_llm_api_autodeploy.py::TestNemotronH::test_auto_dtype[True] is no longer skipped, allowing it to run in the integration test suite.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt
Removed one entry from the SKIP list to re-enable test execution

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description uses only the template with no custom content filled in for Description or Test Coverage sections. Add a clear description explaining why the test was previously waived and why it is now being unwaived. Include relevant test coverage details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a waived test entry for NemotronH accuracy test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32782 [ run ] triggered by Bot. Commit: d76fc44

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32783 [ run ] triggered by Bot. Commit: d76fc44

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32783 [ run ] completed with state SUCCESS. Commit: d76fc44
/LLM/main/L0_MergeRequest_PR pipeline #25370 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32800 [ run ] triggered by Bot. Commit: 23f5733

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32800 [ run ] completed with state SUCCESS. Commit: 23f5733
/LLM/main/L0_MergeRequest_PR pipeline #25379 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie requested a review from suyoggupta January 20, 2026 21:52
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32812 [ run ] triggered by Bot. Commit: 23f5733

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32812 [ run ] completed with state SUCCESS. Commit: 23f5733
/LLM/main/L0_MergeRequest_PR pipeline #25388 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie enabled auto-merge (squash) January 21, 2026 14:34
@lucaslie lucaslie disabled auto-merge January 21, 2026 14:34
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32968 [ run ] triggered by Bot. Commit: 998fd0e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32968 [ run ] completed with state SUCCESS. Commit: 998fd0e
/LLM/main/L0_MergeRequest_PR pipeline #25492 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33196 [ run ] triggered by Bot. Commit: 998fd0e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33196 [ run ] completed with state SUCCESS. Commit: 998fd0e
/LLM/main/L0_MergeRequest_PR pipeline #25648 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit d793bd9 into NVIDIA:main Jan 22, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Jan 22, 2026
@lucaslie lucaslie deleted the ll/fix_5688721 branch January 22, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants