Conversation
JITIFY_USE_CONTEXT_INDEPENDENT_LOADING update for occupancy API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue discovered in FLAME GPU2 PR #1334
and replicated with Jitify 2 where SimpleTest fails on Google Colab and Sheffield HPC with older drivers.
Jitify uses
JITIFY_USE_CONTEXT_INDEPENDENT_LOADINGto definejitify2::CudaFunctionas either aCUkernelor aCUfunctionhoweverConfiguredKernel::configure_1d_max_occupancyunconditionally casts this as aCUFunction(see L2566).Fix is to conditionally obtain the function form the kernel using
cuKernelGetFunctionwhereJITIFY_USE_CONTEXT_INDEPENDENT_LOADINGis defined.