chore: remove initializeProjectDataSafe and use try/catch instead

Author: Fatme

lib/common/commands/device/get-file.ts

@@ -12,7 +12,11 @@ export class GetFileCommand implements ICommand {
 		let appIdentifier = args[1];
 
 		if (!appIdentifier) {
-			this.$projectData.initializeProjectDataSafe();
+			try {
+				this.$projectData.initializeProjectData();
+			} catch (err) {
+				// ignore the error
+			}
 			if (!this.$projectData.projectIdentifiers) {
 				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
 			}

lib/common/commands/device/list-files.ts

@@ -13,7 +13,11 @@ export class ListFilesCommand implements ICommand {
 		let appIdentifier = args[1];
 
 		if (!appIdentifier) {
-			this.$projectData.initializeProjectDataSafe();
+			try {
+				this.$projectData.initializeProjectData();
+			} catch (err) {
+				// ignore the error
+			}
 			if (!this.$projectData.projectIdentifiers) {
 				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
 			}

lib/common/commands/device/put-file.ts

@@ -12,7 +12,11 @@ export class PutFileCommand implements ICommand {
 		let appIdentifier = args[2];
 
 		if (!appIdentifier) {
-			this.$projectData.initializeProjectDataSafe();
+			try {
+				this.$projectData.initializeProjectData();
+			} catch (err) {
+				// ignore the error
+			}
 			if (!this.$projectData.projectIdentifiers) {
 				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
 			}

lib/definitions/project.d.ts

@@ -104,7 +104,6 @@ interface IProjectData extends ICreateProjectData {
 	 * @returns {void}
 	 */
 	initializeProjectData(projectDir?: string): void;
-	initializeProjectDataSafe(projectDir?: string): void;
 	initializeProjectDataFromContent(packageJsonContent: string, nsconfigContent: string, projectDir?: string): void;
 	getAppDirectoryPath(projectDir?: string): string;
 	getAppDirectoryRelativePath(): string;

lib/project-data.ts

@@ -90,14 +90,6 @@ export class ProjectData implements IProjectData {
 		this.errorInvalidProject(projectDir);
 	}
 
-	public initializeProjectDataSafe(projectDir?: string): void {
-		try {
-			return this.initializeProjectData(projectDir);
-		} catch (err) {
-			// ignore the error
-		}
-	}
-
 	public initializeProjectDataFromContent(packageJsonContent: string, nsconfigContent: string, projectDir?: string): void {
 		projectDir = projectDir || this.$projectHelper.projectDir || "";
 		const projectFilePath = this.getProjectFilePath(projectDir);

test/stubs.ts

@@ -336,9 +336,6 @@ export class ProjectDataStub implements IProjectData {
 		this.projectIdentifiers = { android: "", ios: "" };
 		this.projectId = "";
 	}
-	public initializeProjectDataSafe(projectDir?: string): void {
-		this.initializeProjectData(projectDir);
-	}
 	public initializeProjectDataFromContent(): void {
 		return;
 	}