Conversation
|
Thanks for the PR. I'll try to test your changes ASAP. |
amitguptagwl
left a comment
amitguptagwl
left a comment
There was a problem hiding this comment.
I have given a few initial comments. Please check
|
@amitguptagwl Pushed a few changes. These should improve the performance as well. Please check |
kk-08
force-pushed
the
feature/nsValidation
branch
from
986662b to
d5e4ea0
Compare
2. Added check for empty namespace URI
|
@amitguptagwl Suggested changes pushed. Please check and update. |
|
@amitguptagwl Any updates on this? |
|
@kk-08 Sorry for the late response. Please check v4 branch that I have pushed recently. As I had already done these changes, I'm avoiding reviewing the code for same purpose. The changes in v4 are almost done. But I've not completed all the tests yet. As soon I migrate all the tests from master branch to v4 branch. I would be in the condition to publish them. However, there may be some additional changes before going live but that decision can be taken later. |
|
@kk-08 v4 is live now. And changes seem useful, could you please fix the conflicts so I can review and merge the PR. |
3 participants
Purpose / Goal
Adds namespace validation for XML
Closes #265
Type
Description
Perf test results:
Before
validation : 12267.12026907211 requests/second
xml to json : 15042.8615171619 requests/second
xml to json + json string : 13716.406269165005 requests/second
xml to json string : 2662.81536578866 requests/second
xml2js : 5438.29834726833 requests/second
After
validation : 13867.26753315293 requests/second
xml to json : 16933.889511481724 requests/second
xml to json + json string : 15117.827735598856 requests/second
xml to json string : 2567.4248020602818 requests/second
xml2js : 4739.0545687362255 requests/second