Skip to content

replace loaderUtils.parseQuery with loaderUtils.getOptions#409

Open
1pete wants to merge 1 commit intoNekR:masterfrom
1pete:upgrade-loader-utils
Open

replace loaderUtils.parseQuery with loaderUtils.getOptions#409
1pete wants to merge 1 commit intoNekR:masterfrom
1pete:upgrade-loader-utils

Conversation

@1pete
Copy link
Contributor

@1pete 1pete commented Sep 1, 2018

loaderUtils.parseQuery is deprecated, see webpack/loader-utils#56

@GGAlanSmithee
Copy link
Collaborator

GGAlanSmithee commented Sep 5, 2018

Hi @1pete thanks for your contribution. travis is passing, and it looks like AppVeyor complains about a certificate, unrelated to this PR.

@NekR Seems like the deprecation notice was added over a year ago according to the linked thread, is there a reason why we have not updated to use getOptions instead? Should probably be safe to merge this, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants