Conversation
suryag1201
commented
Oct 29, 2025
| throw new InvalidParameterValueException("createAsync: callback should not be null"); | ||
| } | ||
| try { | ||
| s_logger.info("createAsync: Volume creation starting for data store [{}] and data object [{}] of type [{}]", |
suryag1201
commented
Oct 29, 2025
| throw new CloudRuntimeException("createCloudStackVolume : Storage Pool not found for id: " + dataStore.getId()); | ||
| } | ||
| Map<String, String> details = storagePoolDetailsDao.listDetailsKeyPairs(dataStore.getId()); | ||
| if(details == null || details.isEmpty()) { |
Author
There was a problem hiding this comment.
create util method for ontap connection
suryag1201
commented
Oct 29, 2025
| s_logger.info("createCloudStackVolume : Creating Lun with cloudstackVolume request {} ", cloudstackVolume); | ||
| if (cloudstackVolume == null || cloudstackVolume.getLun() == null) { | ||
| s_logger.error("createCloudStackVolume: LUN creation failed. Invalid cloudstackVolume request: {}", cloudstackVolume); | ||
| throw new CloudRuntimeException("createCloudStackVolume : Failed to create Lun, invalid cloudstackVolume request"); |
Author
There was a problem hiding this comment.
change invalid cloudstackVolume request logger change
suryag1201
commented
Oct 29, 2025
| String authHeader = utils.generateAuthHeader(storage.getUsername(), storage.getPassword()); | ||
| // Create URI for lun creation | ||
| URI url = utils.generateURI(Constants.CREATE_LUN); | ||
| OntapResponse<Lun> createdLun = sanFeignClient.createLun(url, authHeader, true, cloudstackVolume.getLun()); |
Author
There was a problem hiding this comment.
add TODO, based on testing need to covert this createLun to Async
suryag1201
commented
Oct 29, 2025
| lunSpace.setSize(dataObject.getSize()); | ||
| lunRequest.setSpace(lunSpace); | ||
|
|
||
| String lunFullName = Constants.VOLUME_PATH_PREFIX + storagePool.getName() + Constants.PATH_SEPARATOR + dataObject.getName(); |
Author
There was a problem hiding this comment.
add example for lun full name
|
|
||
| public class OntapPrimaryDatastoreDriver implements PrimaryDataStoreDriver { | ||
|
|
||
| private static final Logger s_logger = (Logger)LogManager.getLogger(OntapPrimaryDatastoreDriver.class); |
piyush5netapp
approved these changes
Oct 29, 2025
rajiv-jain-netapp
approved these changes
Oct 29, 2025
sandeeplocharla
pushed a commit
that referenced
this pull request
Jan 30, 2026
* CSTACKEX-35 Create Async * CSTACKEX-35 Added Null and empty check * CSTACKEX-35 Resolved review comments * CSTACKEX-35 Removed Type Casting for logger --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create Async for ISCSI
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?