Skip to content

fix make scrambled password segmentation fault bug when password longer than 26 characters #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heat1024 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix make scrambled password segmentation fault bug when password longer than 26 characters #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/password_323.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ void make_scrambled_password(char scrambled_password[42], const char password[25
SHA1Init(&ctx);
SHA1Update(&ctx, h0, sizeof h0);
#ifdef HAVE_EXPLICIT_BZERO
explicit_bzero(h0, strlen(password));
explicit_bzero(h0, sizeof h0);
#else
volatile char *pnt_ = (volatile char *) h0;
size_t i = (size_t) 0U;

while (i < strlen(password)) {
while (i < sizeof h0) {
pnt_[i++] = 0U;
}
#endif
Expand Down